Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization performance #74

Closed
eric-millin opened this issue Mar 20, 2023 · 2 comments
Closed

Serialization performance #74

eric-millin opened this issue Mar 20, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@eric-millin
Copy link
Contributor

JsonSerializationWriter looks like it could be a good deal more efficient. With a small change I improved performance by about 50% and the tests pass. Those numbers come from benchmarks, so they only mean so much. I can PR the change at some point if you're interested, if not, no worries.

eric-millin@1366790

Here are the differences in the benchmarks

Current   	  111204	     10472 ns/op	   20806 B/op	     211 allocs/op
AfterChange 	  170420	      6276 ns/op	    2095 B/op	     100 allocs/op
@baywet
Copy link
Member

baywet commented Mar 20, 2023

Thanks for the suggestion. We'd be very happy to see that performance improvement in the code-base assuming it doesn't trade-off functionality.

@baywet baywet added enhancement New feature or request need author feedback labels Mar 20, 2023
@eric-millin
Copy link
Contributor Author

eric-millin commented Mar 31, 2023

We're not really impacted by this issue. Perhaps I'll do it on a Friday afternoon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants