Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minject defaults to mimalloc-override again... #989

Open
gitoss opened this issue Jan 13, 2025 · 1 comment
Open

minject defaults to mimalloc-override again... #989

gitoss opened this issue Jan 13, 2025 · 1 comment

Comments

@gitoss
Copy link

gitoss commented Jan 13, 2025

The latestest and greatestest commit f4c3a90 silently makes minject default to mimalloc-override.dll again - this behavior was recently changed by 4b73139

Because the compiled dll is named w/o the -override suffix, binaries treated with minject.exe either fail because of the missing mimject-override.dll or minject.exe has to be used w/ --postfix=

Either w/ or w/o -override seems fine to me personally, it just would make sense to decide either way :-)

@daanx
Copy link
Collaborator

daanx commented Jan 13, 2025

Ah yes -- thanks for the heads-up. I am currently changing names of output to be consistent across platforms and mimalloc is always mimalloc.dll now (without override) so it is best to make that the default in minject as well. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants