Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

mhegazy/typescript#v1.5-beta2 #36

Open
johnpapa opened this issue Jun 11, 2015 · 8 comments
Open

mhegazy/typescript#v1.5-beta2 #36

johnpapa opened this issue Jun 11, 2015 · 8 comments

Comments

@johnpapa
Copy link

The typescript version is not the latest one in npm.

{
    "name": "ngconf2015-demo",
    "version": "0.1.0",
    "repository": { "url": "https://github.com/Microsoft/ngconf2015demo" },
    "dependencies": {
        "typescript": "mhegazy/typescript#v1.5-beta2",
        "systemjs": "0.17.1"
    }
}

I found this to be important as the one in the demo has expirementalDecorators, which is needed by the demo. But nowhere is this explained that if you grab TypeScript 1.5 beta that you will not get this.

Please update the demo and readme to explain how you recommended getting TS for this.

@mhegazy
Copy link
Contributor

mhegazy commented Jun 11, 2015

These changes should be in TypeScript 1.5.2 (next release). There are some changes that went in after TypeScript-1.5-beta that was needed for SystemJS integration, for that we have a 1.5.2-prelease snap in mhegazy/typescript#v1.5-beta2.

I will update the readme accordingly.

@mhegazy
Copy link
Contributor

mhegazy commented Jun 11, 2015

updated in db9cd75

@johnpapa
Copy link
Author

Seems odd that these are not in a branch in the TS repo. no?

@mhegazy
Copy link
Contributor

mhegazy commented Jun 12, 2015

We had a branch, then ppl complained that they need to clone the whole repo.

@johnpapa
Copy link
Author

Ah.

If I use typescript 1.5-beta and remove the experimental decorator option, the demo still works. Is that the recommended approach for now?

@mhegazy
Copy link
Contributor

mhegazy commented Jun 18, 2015

I would say so.

@mhegazy
Copy link
Contributor

mhegazy commented Jun 18, 2015

if you want to use an "official" branch instead, consider this: https://github.com/Microsoft/TypeScript/tree/release-1.5

@johnpapa
Copy link
Author

thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants