Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete profiles in Terminal #15542

Closed
mridun-gupta opened this issue Jun 13, 2023 · 21 comments
Closed

Unable to delete profiles in Terminal #15542

mridun-gupta opened this issue Jun 13, 2023 · 21 comments
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal.

Comments

@mridun-gupta
Copy link

mridun-gupta commented Jun 13, 2023

Windows Terminal version

1.17.11461.0

Windows build number

No response

Other Software

No response

Steps to reproduce

1.) Make a custom terminal profile
3.) Try deleting it, it shows the option to delete

Expected Behavior

The profile should be deleted by the backend OS smoothly.

Actual Behavior

It won't get deleted.

Recording.2023-06-13.094631.mp4
@mridun-gupta mridun-gupta added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 13, 2023
@lhecker
Copy link
Member

lhecker commented Jun 13, 2023

I assume this problem persists even after you restart Windows Terminal right? Could you provide us with a settings.json file that reproduces the issue?

@lhecker lhecker added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. Area-SettingsUI Anything specific to the SUI labels Jun 13, 2023
@mridun-gupta
Copy link
Author

Yes, It persists even after restarting terminal or even Windows 11 (only happening on Windows 11, on Windows 10 working fine)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 13, 2023
@mridun-gupta
Copy link
Author

mridun-gupta commented Jun 13, 2023

settings.txt

converted json to txt (for direct code of json check history of this comment
the profiles are unavailable in the json

@carlos-zamora
Copy link
Member

Hi @mridun-gupta. This seems to be the wrong settings file. The profiles should be in the JSON. Additionally, the "SharePoint Online Management Shell" profile is in the JSON but isn't in the video you shared.

Just to be sure, click on the "Open JSON file" button in the navigation view, then send us a copy of that one. Also, curious, do you have multiple versions of Windows Terminal installed?

@carlos-zamora carlos-zamora added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jun 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 15, 2023
@mridun-gupta
Copy link
Author

Hi @mridun-gupta. This seems to be the wrong settings file. The profiles should be in the JSON. Additionally, the "SharePoint Online Management Shell" profile is in the JSON but isn't in the video you shared.

Just to be sure, click on the "Open JSON file" button in the navigation view, then send us a copy of that one. Also, curious, do you have multiple versions of Windows Terminal installed?

The JSON file is correct, SharePoint Online Management Shell is added just to test whether the forum solutions might help or not, and now I unable to delete it too, SpeedTest profiles shown in shared video are not mentioned in the JSON file too (which I do mentioned while sharing JSON file.)

@mridun-gupta
Copy link
Author

Yes it has errors and it needs to be fixed . Do you want our help and support On Thu, Jun 15, 2023 at 3:32 AM Mridun Gupta < @.> wrote:

Hi @mridun-gupta https://github.com/mridun-gupta. This seems to be the wrong settings file. The profiles should be in the JSON. Additionally, the "SharePoint Online Management Shell" profile is in the JSON but isn't in the video you shared. Just to be sure, click on the "Open JSON file" button in the navigation view, then send us a copy of that one. Also, curious, do you have multiple versions of Windows Terminal installed? The JSON file is correct, SharePoint Online Management Shell is added just to test whether the forum solutions might help or not, and now I unable to delete it too, SpeedTest profiles shown in shared video are not mentioned in the JSON file too (which I do mentioned while sharing JSON file.) — Reply to this email directly, view it on GitHub <#15542 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BASR7VRXJOJY7AJEFI4PMQLXLJX3JANCNFSM6AAAAAAZEIEDLQ . You are receiving this because you are subscribed to this thread.Message ID: @.
>

Yes, please. It will be very kind of you to help me out and try to fix the issue in future updates (if there is something messed up in the source code itself).

@microsoft microsoft deleted a comment Jun 15, 2023
@DHowett
Copy link
Member

DHowett commented Jun 15, 2023

Just so you know, that person is not affiliated with our team even though the language they used indicated that they might be.

Thanks for the additional information. Can you share the file path to that settings file? In addition, do you have multiple versions of Windows Terminal installed?

@DHowett
Copy link
Member

DHowett commented Jun 15, 2023

Typically, if a profile is present in the settings interface it must be present in the JSON file. There are likely multiple novel bugs here that we have never seen reports of before. :)

@mridun-gupta
Copy link
Author

Just so you know, that person is not affiliated with our team even though the language they used indicated that they might be.

Thanks for the additional information. Can you share the file path to that settings file? In addition, do you have multiple versions of Windows Terminal installed?

Thank you for informing sir, I only use a single Windows Terminal installed on my Windows 11.

@mridun-gupta
Copy link
Author

Typically, if a profile is present in the settings interface it must be present in the JSON file. There are likely multiple novel bugs here that we have never seen reports of before. :)

Yeah, I had almost the same configuration earlier in Windows 10, I had no issues with it, but when I made it to Windows 11, Terminal started producing errors.

@microsoft microsoft deleted a comment Jun 15, 2023
@microsoft microsoft deleted a comment Jun 15, 2023
@microsoft microsoft deleted a comment Jun 15, 2023
@microsoft microsoft deleted a comment Jun 15, 2023
@microsoft microsoft deleted a comment Jun 15, 2023
@mridun-gupta
Copy link
Author

Thank you, @microsoft for deleting the spammy messages.

@carlos-zamora carlos-zamora removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jun 21, 2023
@carlos-zamora carlos-zamora added the Priority-2 A description (P2) label Jun 21, 2023
@carlos-zamora carlos-zamora added this to the Backlog milestone Jun 21, 2023
@DHowett
Copy link
Member

DHowett commented Jun 21, 2023

Thanks for all the info. Right now, we don't know what is happening and so the bug will require a bit more investigation.

@Limyx826
Copy link

Limyx826 commented Jul 22, 2023

Just notify I have the same issue when trying to delete profiles.
Terminal Version: 1.17.11461.0
Windows 10 22H2 build 19045.3208.

@Limyx826
Copy link

LocalState.zip
Attached the entire local state folder for reference.

@jtnord
Copy link

jtnord commented Sep 4, 2023

I also have this issue - is there anything I can do to provide some more information about this?
1.17.11461.0 windows 11 21H2

@lhecker lhecker added the Needs-Attention The core contributors need to come back around and look at this ASAP. label Sep 4, 2023
@lhecker lhecker modified the milestones: Backlog, Terminal v1.20 Sep 4, 2023
@codecruisedor
Copy link
Contributor

I don't know if this is already known, but just mentioning this here since I noticed it.

I have Windows 10 Version 10.0.19045.3324, Terminal Version: 1.17.11461.0.

I delete a profile and it does not get deleted. So, I checked in the settings JSON file and it still contained the profile(was not removed). Only after clicking the save button did I see the profile getting deleted, which subsequently deleted the profile in the JSON file. Hitting save triggers the deletion it seems. Attached is a video for reference, in which I deleted the profile named 'Profile7'.

Desktop.2023.09.14.-.23.06.31.01.mp4

@mridun-gupta
Copy link
Author

I don't know if this is already known, but just mentioning this here since I noticed it.

I have Windows 10 Version 10.0.19045.3324, Terminal Version: 1.17.11461.0.

I delete a profile and it does not get deleted. So, I checked in the settings JSON file and it still contained the profile(was not removed). Only after clicking the save button did I see the profile getting deleted, which subsequently deleted the profile in the JSON file. Hitting save triggers the deletion it seems. Attached is a video for reference, in which I deleted the profile named 'Profile7'.

Desktop.2023.09.14.-.23.06.31.01.mp4

Thank you @codecruisedor for sharing this clip, but maybe the team have either make this as a disclaimer in settings or might make it less confusing for a regular user.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Sep 14, 2023
@zadjii-msft zadjii-msft removed this from the Terminal v1.20 milestone Sep 19, 2023
@rsenna
Copy link

rsenna commented Jan 13, 2024

I think this is related to UX bugs.

It would be OK to keep the current behavior, but that in combination with the UX issues below, makes it very hard for a newbie or casual user to deal with profiles in a proper manner:

  • There is no indication in the Settings window that changes have been made, and that user needs to click on Save after deleting a profile.
  • The "Discard Changes" button is always visible and enabled, even when no changes have been made.
  • If one simply closes the setting tab, there's also no indication of pending changes, and those are simply lost.

Btw, I also struggled with the problem described by the OP, and I was only able to "fix" it by following @codecruisedor's suggestion.

@mridun-gupta
Copy link
Author

mridun-gupta commented Jan 15, 2024

@rsenna Do you suggest that I reopen this issue again (in the public interest)?

@mridun-gupta mridun-gupta reopened this Jan 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 17, 2024
@pascal456
Copy link

pascal456 commented Aug 20, 2024

I also stumbled upon this issue-thread while looking for a solution. I experienced it exactly like described above (clip).

  • go to settings
  • select profile
  • click delete
  • confirm deletion (❗)
  • profile is removed from the settings navigation on the left (this is where the confusion comes from)

Now I closed the settings tab and from the new tab dop-down menu the profile was still available. Also when opening the settings again, the profile appeared in all menus again.

Solution: All the steps but additionally click on save in the profile settings window that is automatically selected after confirmation of deletion (which actually belongs to another profile than the one I deleted 😵)

@carlos-zamora carlos-zamora removed the Needs-Attention The core contributors need to come back around and look at this ASAP. label Jan 15, 2025
@carlos-zamora
Copy link
Member

Looping back on this. Closing as by design since it's a matter of clicking the "save" button.

@carlos-zamora carlos-zamora closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

12 participants