Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste with Ctrl removes leading special character in SSH #17264

Open
fbienz opened this issue May 14, 2024 · 4 comments
Open

Paste with Ctrl removes leading special character in SSH #17264

fbienz opened this issue May 14, 2024 · 4 comments
Labels
Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal.

Comments

@fbienz
Copy link

fbienz commented May 14, 2024

Windows Terminal version

1.20.11271.0

Windows build number

10.0.22631.0

Other Software

openssh-client/jammy-security,now 1:8.9p1-3ubuntu0.6

Steps to reproduce

Connect to remote Linux server via SSH using WSL or Powershell.
Paste a string starting with one of these characters []{} using Ctrl+Shift+v, Ctrl+v or Ctrl+ Right Click.
Example: [rlkdjf[]{}dt

Expected Behavior

Complete String gets pasted into the Shell.
image

Actual Behavior

Leading character and the second character are removed from the String.
image

Using Shift+Insert or Right Click does not remove the leading characters.

This has worked until the latest update (winget package). I'm assuming this is form the 1.20 update.

@fbienz fbienz added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 14, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@carlos-zamora carlos-zamora added this to the Terminal v1.22 milestone May 15, 2024
@carlos-zamora carlos-zamora added Area-VT Virtual Terminal sequence support Product-Terminal The new Windows Terminal. zStable-Service-Queued-1.12 and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 15, 2024
@DHowett
Copy link
Member

DHowett commented Aug 22, 2024

Thanks for the report! I'm sorry that we haven't been able to reproduce this yet. I just gave it a try with 1.22 (Canary) in zsh and bash over ssh, one of which supports bracketed paste mode and the other of which does not.

Would you be able to test this out in the Canary channel/?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 22, 2024
@fbienz
Copy link
Author

fbienz commented Aug 23, 2024

Hi,

I tested it again using following version:
Terminal (Portable)
Version: 1.22.240822001-llm

The Problem stays the same.

I have learned a few things though:

  • zsh does not have this issue in either version. (although i could only test it by launching zsh through bash)
  • The behavior is different for Debian 10 vs Debian 12 remote host

In case the remote host is Debian 12, pasting works without the brackets being removed, except when pasting a password in the password mask.
In that case only right Shift+Insert and Right Click paste correctly.

Since there were some updates, this is the current version I'm using: 1.20.11781.0

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 23, 2024
@carlos-zamora carlos-zamora removed the Needs-Attention The core contributors need to come back around and look at this ASAP. label Jan 15, 2025
@carlos-zamora
Copy link
Member

Does this repro if you use ssh within WSL /?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 15, 2025
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.21 Servicing Pipeline Jan 15, 2025
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.22 Servicing Pipeline Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal.
Projects
Status: To Cherry Pick
Status: To Cherry Pick
Development

No branches or pull requests

3 participants