Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation menu automatically expands and overlaps settings page content in small windows #17700

Open
ghost opened this issue Aug 10, 2024 · 5 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@ghost
Copy link

ghost commented Aug 10, 2024

Windows Terminal version

1.21.1772.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

  1. Open Windows Terminal.
  2. Resize the Terminal window to a very small size.
  3. Open the settings page.
  4. Observe that the navigation menu automatically expands and overlaps the content of the settings page.

Expected Behavior

The navigation menu should remain hidden by default in small windows to prevent overlapping with the settings page content.

Actual Behavior

issue

@ghost ghost added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 10, 2024
@j4james
Copy link
Collaborator

j4james commented Aug 11, 2024

I think this is duplicate of #16906, and it looks like there is already a PR to fix it - I'm not sure why that hasn't been merged yet.

@ghost
Copy link
Author

ghost commented Aug 11, 2024

I think this is duplicate of #16906, and it looks like there is already a PR to fix it - I'm not sure why that hasn't been merged yet.

Hi, I don't think this is a duplicate.

I'm mainly wondering why the navigation menu automatically expands and covers the page content, even if the Terminal window is small.

I believe the correct thing to do would be to check the size of the window, and if it is too small, the menu should be hidden by default, but the user can click to open it.

@j4james
Copy link
Collaborator

j4james commented Aug 11, 2024

I initially thought it might have been opening the menu intentionally, because in most cases the first thing you'll do is navigate to one of the other sections, and you can't do that in the narrow view without first opening the menu. However, if that was the intention, I would have expected the menu to close as soon you selected something, which it doesn't seem to do. So I think maybe you're right, and the menu should just be hidden by default.

@carlos-zamora carlos-zamora added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Priority-3 A description (P3) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 14, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Aug 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 14, 2024
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Aug 14, 2024
@carlos-zamora
Copy link
Member

Thanks for filing. Looks like the VisualStateManager in the Navigation view is having trouble deciding whether it should be open or closed when you open the settings UI. This should be investigated further in the Navigation view code in XAML directly.

@j4james
Copy link
Collaborator

j4james commented Aug 15, 2024

Btw, I forgot to add that I tested this on a Windows 11 machine, and that didn't seem to have this problem (i.e. it doesn't open the settings by default), so this might just be a Windows 10 bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants