Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functional-Open dropdown]- User is not able to perform action using shortcuts defined for the dropdown menu items. #8462

Closed
Chandresh1007 opened this issue Dec 2, 2020 · 4 comments
Closed

[Functional-Open dropdown]- User is not able to perform action using shortcuts defined for the dropdown menu items. #8462

Chandresh1007 opened this issue Dec 2, 2020 · 4 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. WindowsTerminal_Win32
Milestone
Terminal v2.0

Comments

@Chandresh1007
Copy link

Chandresh1007 commented Dec 2, 2020 •
edited
Loading

User Experience:
Users who rely on screen reader/Keyboard will not be able to perform action efficiently if shortcuts are not working for the dropdown menu items.

Test Environment:
OS: Win 10 2004 Build (20262.1010)
App: Windows Terminal
App version: 1.4.3243.0

Repro Steps:

  1. Open Windows terminal app
  2. Press "Ctrl+shift+Space" key to open the dropdown control.
  3. Navigate to the Menu items.
  4. Now press shortcut key defined for menu item say "Ctrl+," (which is defined for settings menu item).
  5. Observe the issue.

Actual Result:
User is not able to perform action using shortcuts defined for the dropdown menu items.
Pressing shortcut key defined for menu items, nothing is getting activated.

Expected Result:
User should be able to perform action using shortcuts defined for the dropdown menu items.
Pressing shortcut key "Ctrl+," settings should get open.

Functional_dropdown_menu keys not working.zip
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 2, 2020
@Chandresh1007 Chandresh1007 added HCL-E+D Accessibility tracking Product-Terminal The new Windows Terminal. labels Dec 2, 2020
@zadjii-msft
Copy link
Member

Yep, that makes sense. This is a variant of #6679, but with the new tab dropdown, instead of the command palette.

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. labels Dec 2, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 2, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Dec 2, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 3, 2020
@zadjii-msft zadjii-msft mentioned this issue Dec 3, 2020
Closed
@cinnamon-msft cinnamon-msft added the Priority-0 Bugs that we consider release-blocking/recall-class (P0) label Dec 4, 2020
@Chandresh1007 Chandresh1007 added HCL-WindowsConsole Accessibility tracking HCL-WindowsTerminal Accessibility tracking labels Dec 7, 2020
@KalleOlaviNiemitalo
Copy link

Do users really expect keyboard shortcuts to work while a menu is open? Compare to Notepad in U.S. English:

  1. Start Notepad.
  2. Press Ctrl+Shift+S. The "Save As" dialog box opens.
  3. Press Esc. The "Save As" dialog box closes.
  4. Press Alt+F. The "File" menu opens.
  5. Press the Down arrow key four times. The "Save As… Ctrl+Shift+S" menu item becomes highlighted and the menu remains open.
  6. Press Ctrl+Shift+S. The "Save As" dialog box does not open. Instead, there is a sound, and the menu remains open.

@akashk077
Copy link

Do users really expect keyboard shortcuts to work while a menu is open? Compare to Notepad in U.S. English:

  1. Start Notepad.
  2. Press Ctrl+Shift+S. The "Save As" dialog box opens.
  3. Press Esc. The "Save As" dialog box closes.
  4. Press Alt+F. The "File" menu opens.
  5. Press the Down arrow key four times. The "Save As… Ctrl+Shift+S" menu item becomes highlighted and the menu remains open.
  6. Press Ctrl+Shift+S. The "Save As" dialog box does not open. Instead, there is a sound, and the menu remains open.

@KalleOlaviNiemitalo
I completely agree with your point.
If we are inside the menu and we'll use the shortcut key, it won't work.
@Chandresh1007
If the behaviour is just like @KalleOlaviNiemitalo then it is not an issue.
Else, please describe.

@Chandresh1007
Copy link
Author

As the shortcut keys are working when the menu is closed. Hence, closing this bug.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Dec 28, 2020
@Priyanka-Chauhan123 Priyanka-Chauhan123 removed the HCL-WindowsConsole Accessibility tracking label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. WindowsTerminal_Win32
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
7 participants
@DHowett @zadjii-msft @KalleOlaviNiemitalo @cinnamon-msft @Chandresh1007 @Priyanka-Chauhan123 @akashk077