Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screen Reader - Open and close New Tab]: Screen reader does not announce position number for the tabs navigating via "Ctrl+Tab" or "Ctrl+Shift+Tab" key. #8474

Closed
Chandresh1007 opened this issue Dec 3, 2020 · 11 comments
Assignees
Labels
A11yCO Accessibility tracking A11ySev3 Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. WindowsTerminal_Win32

Comments

@Chandresh1007
Copy link

Chandresh1007 commented Dec 3, 2020

User Experience:
If the correct information and relationships are not provided, it would be difficult for people with different disabilities as the information and relationships that are implied by visual or auditory formatting will not be preserved when the presentation format changes.
Having these structures and these relationships programmatically determined or available in text ensures that information important for comprehension will be perceivable to all.

Test Environment:
OS: Win 10 2004 Build (20262.1010)
App: Windows Terminal
App version: 1.4.3243.0

Repro Steps:

  1. Open Windows terminal app.
  2. Launch Narrator.
  3. Press "Ctrl+Shift+T" to open multiple tabs.
  4. Now press "Ctrl+Tab" or "Ctrl+Shift+Tab" key to navigate between tabs.
  5. Observe the issue.

Actual Result:
Screen reader does not announce position number for the tabs navigating via "Ctrl+Tab" or "Ctrl+Shift+Tab" key.

Expected Result:
Screen reader should announce the position number for the tabs navigating via "Ctrl+Tab" or "Ctrl+Shift+Tab" key.
For e.g. If total 5 tabs are present and currently the focus is at 3rd tab then narrator should announce it as "3of 5".

Note: Same issue repro with NVDA.

Observation: In scan mode narrator announces position number.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc=%7B54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4%7D&cid=a7f80d30-34d6-4e03-af19-fa3c97a5bf31

MAS1.3.1_Position no does not get announced for tabs.zip

Tab item_code snippet

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 3, 2020
@Chandresh1007 Chandresh1007 changed the title [Screen Reader - Open and close New Tab]: Screen reader does no announce position number for the tabs navigating via "Ctrl+Tab" or "Ctrl+Shift+Tab" key. [Screen Reader - Open and close New Tab]: Screen reader does not announce position number for the tabs navigating via "Ctrl+Tab" or "Ctrl+Shift+Tab" key. Dec 3, 2020
@Chandresh1007 Chandresh1007 added HCL-E+D Accessibility tracking Product-Terminal The new Windows Terminal. labels Dec 3, 2020
@zadjii-msft
Copy link
Member

I'm guessing that this is the same thing as #8464, where we provide a little bit of metadata in the message. /cc @carlos-zamora

@zadjii-msft zadjii-msft added the Area-Accessibility Issues related to accessibility label Dec 3, 2020
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 4, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 4, 2020
@cinnamon-msft cinnamon-msft added the Priority-3 A description (P3) label Dec 4, 2020
@Chandresh1007 Chandresh1007 added A11yWCAG Accessibility tracking HCL-WindowsConsole Accessibility tracking HCL-WindowsTerminal Accessibility tracking labels Dec 7, 2020
@akash07k
Copy link

@zadjii-msft
Any update on this issue?

@zadjii-msft
Copy link
Member

@akash07k @carlos-zamora is the one who's currently working on our accessibility bugs.

Carlos, do browsers do this? If so, then I'm betting this is also something that the WinUI team should implement themselves, like #8464

@akash07k
Copy link

Thanks @zadjii-msft
@carlos-zamora I'd love to know the progress on this issue if possible. :-)

@akash07k @carlos-zamora is the one who's currently working on our accessibility bugs.

Carlos, do browsers do this? If so, then I'm betting this is also something that the WinUI team should implement themselves, like #8464

Ya, if WinUI team implements it then it will be fixed for many more apps too and it would be win-win for all.
I'd be investigating this issue in more detail tonight.

@carlos-zamora
Copy link
Member

I have good news and bad news.
Good news:

  • tested this on v1.7.501.0 (preview selfhost) and v1.5.10411.0 (stable public release). It got fixed (probably by WinUI)

Bad news:

  • seeing a regression on v1.7.501.0. Tab names are not being read out by the screen reader. Submitting a separate issue for that.

@carlos-zamora
Copy link
Member

@Chandresh1007 since this is fixed now, could you close the bug? Thanks.

@DHowett
Copy link
Member

DHowett commented Feb 23, 2021

Er, I tried this in 1.7 and didn’t hear an announcement for the tab index. Maybe the tab switcher interferes?

@akash07k
Copy link

@carlos-zamora
Thanks for confirming,
Can you please let me know that where can I find that selfhosted build? is it publicly available or not?
And, please give the issue link for "tab names not being read" Would love to track it's progress.

I have good news and bad news.
Good news:

  • tested this on v1.7.501.0 (preview selfhost) and v1.5.10411.0 (stable public release). It got fixed (probably by WinUI)

Bad news:

  • seeing a regression on v1.7.501.0. Tab names are not being read out by the screen reader. Submitting a separate issue for that.

@carlos-zamora
Copy link
Member

Apologies. I was in the process of writing a comment then got distracted with something else. The tab switcher actually "fixes" this functionality. However, when the tab switcher is not enabled, this bug occurs. So it's still valid, I think?

The default functionality setting includes the tab switcher though. That's the only reason I can think of disqualifying it, but that's not a good enough reason, I think.

@Chandresh1007
Copy link
Author

Issue is fixed. Now the screen reader is announcing the position number along with its name and state. Verified on following Test Environment:
OS: Win 10 2004 Build (21301.1010)
App: Windows Terminal
App version: 1.5.10411.0
Hence, closing the bug.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Feb 25, 2021
@awalia13 awalia13 added the A11yCO Accessibility tracking label Mar 10, 2021
@Priyanka-Chauhan123 Priyanka-Chauhan123 added the A11ySev3 Accessibility tracking label Jun 10, 2021
@Priyanka-Chauhan123 Priyanka-Chauhan123 removed the HCL-WindowsConsole Accessibility tracking label Jul 21, 2021
@Priyanka-Chauhan123
Copy link
Collaborator

Closing the bug as issue has been fixed.

@Priyanka-Chauhan123 Priyanka-Chauhan123 added the A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11yCO Accessibility tracking A11ySev3 Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. WindowsTerminal_Win32
Projects
None yet
Development

No branches or pull requests

8 participants