From 2f19d4e7ecf35453f3fe25cb6f3094bd1f13f847 Mon Sep 17 00:00:00 2001 From: Timothee Guerin Date: Fri, 28 Feb 2025 15:19:32 -0800 Subject: [PATCH] speed up binskim (#6205) With the current pattern, binskim takes 3-5min everytime it runs which is on every artifact we produce, which basically close to double the build time... Maybe one day ms tooling will learn to use an efficient glob library --- eng/tsp-core/pipelines/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/tsp-core/pipelines/publish.yml b/eng/tsp-core/pipelines/publish.yml index 0370880051..54cea54b69 100644 --- a/eng/tsp-core/pipelines/publish.yml +++ b/eng/tsp-core/pipelines/publish.yml @@ -16,7 +16,7 @@ extends: template: /eng/common/pipelines/templates/1es-redirect.yml parameters: BinSkimSettings: - analyzeTargetGlob: +:file|**/dist/*.exe;-:f|**/tsp.exe # Flag issue with node binary which we can't fix https://github.com/nodejs/node/issues/42100 + analyzeTargetGlob: +:file|*.exe;-:f|**/tsp.exe # Flag issue with node binary which we can't fix https://github.com/nodejs/node/issues/42100 variables: - template: /eng/tsp-core/pipelines/templates/variables/globals.yml@self