From fb08dfa7b24df868716ff67a5eeb97203b20cfb8 Mon Sep 17 00:00:00 2001 From: Jose Manuel Heredia Hidalgo Date: Thu, 27 Feb 2025 06:36:10 +0000 Subject: [PATCH] Ignore lint warning for getDiscriminatedUnion --- .../src/typescript/components/type-transform.tsx | 1 + .../transforms/json/json-transform-discriminator.tsx | 4 ++-- packages/http-client/src/typekit/kits/model.ts | 11 +++-------- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/packages/emitter-framework/src/typescript/components/type-transform.tsx b/packages/emitter-framework/src/typescript/components/type-transform.tsx index 21d064c347f..df063de6753 100644 --- a/packages/emitter-framework/src/typescript/components/type-transform.tsx +++ b/packages/emitter-framework/src/typescript/components/type-transform.tsx @@ -55,6 +55,7 @@ interface DiscriminateExpressionProps { } function DiscriminateExpression(props: DiscriminateExpressionProps) { + // eslint-disable-next-line @typescript-eslint/no-deprecated const [discriminatedUnion] = getDiscriminatedUnion(props.type, props.discriminator)!; const discriminatorRef = `item.${props.discriminator.propertyName}`; diff --git a/packages/http-client-js/src/components/transforms/json/json-transform-discriminator.tsx b/packages/http-client-js/src/components/transforms/json/json-transform-discriminator.tsx index 0b11c38981f..345b123f473 100644 --- a/packages/http-client-js/src/components/transforms/json/json-transform-discriminator.tsx +++ b/packages/http-client-js/src/components/transforms/json/json-transform-discriminator.tsx @@ -5,7 +5,6 @@ import { DiscriminatedUnionLegacy, Discriminator, getDiscriminatedUnion, - ignoreDiagnostics, Model, Union, } from "@typespec/compiler"; @@ -30,7 +29,8 @@ export function JsonTransformDiscriminator(props: JsonTransformDiscriminatorProp let propertyName: string | undefined = discriminatedUnion?.options.discriminatorPropertyName; if (!discriminatedUnion && props.discriminator) { // eslint-disable-next-line @typescript-eslint/no-deprecated - discriminatedUnion = ignoreDiagnostics(getDiscriminatedUnion(props.type, props.discriminator)); + const [result] = getDiscriminatedUnion(props.type, props.discriminator); + discriminatedUnion = result; propertyName = props.discriminator.propertyName; } diff --git a/packages/http-client/src/typekit/kits/model.ts b/packages/http-client/src/typekit/kits/model.ts index 0d2b8330317..3fcd48ab92c 100644 --- a/packages/http-client/src/typekit/kits/model.ts +++ b/packages/http-client/src/typekit/kits/model.ts @@ -1,10 +1,4 @@ -import { - getDiscriminatedUnion, - getDiscriminator, - ignoreDiagnostics, - Model, - ModelProperty, -} from "@typespec/compiler"; +import { getDiscriminatedUnion, getDiscriminator, Model, ModelProperty } from "@typespec/compiler"; import { defineKit } from "@typespec/compiler/experimental/typekit"; import { AccessKit, getAccess, getName, getUsage, NameKit, UsageKit } from "./utils.js"; @@ -83,7 +77,8 @@ defineKit({ getDiscriminatedSubtypes(model) { const disc = getDiscriminator(this.program, model); if (!disc) return {}; - const discriminatedUnion = ignoreDiagnostics(getDiscriminatedUnion(model, disc)); + // eslint-disable-next-line @typescript-eslint/no-deprecated + const [discriminatedUnion] = getDiscriminatedUnion(model, disc); return discriminatedUnion?.variants || {}; }, getBaseModel(model) {