Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick open location can push workbench #238196

Closed
bpasero opened this issue Jan 18, 2025 · 4 comments · Fixed by #238421
Closed

Quick open location can push workbench #238196

bpasero opened this issue Jan 18, 2025 · 4 comments · Fixed by #238421
Assignees
@TylerLeonhardt
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
January 2025

Comments

@bpasero
Copy link
Member

bpasero commented Jan 18, 2025

Image

Steps:

  • have a window that is as large as the screen size
  • move quick open to the bottom right
  • make window smaller
  • bring up quick open

🐛 it seems to push the entire workbench grid out of view 🤯
@bpasero bpasero added the important Issue identified as high-priority label Jan 18, 2025
@TylerLeonhardt TylerLeonhardt closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2025
@TylerLeonhardt
Copy link
Member

Duplicate, fixed Monday

@TylerLeonhardt TylerLeonhardt removed the important Issue identified as high-priority label Jan 18, 2025
@TylerLeonhardt
Copy link
Member

#238189

@bpasero
Copy link
Member Author

bpasero commented Jan 18, 2025 •
edited
Loading

@TylerLeonhardt this reproduces running out of sources with latest changes from main including #238189

Image

@bpasero bpasero reopened this Jan 18, 2025
@TylerLeonhardt
Copy link
Member

The case I didn't cover in the original PR:

  • move picker to corner
  • HIDE PICKER
  • change layout
  • show picker

@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Jan 18, 2025
@TylerLeonhardt TylerLeonhardt added this to the January 2025 milestone Jan 18, 2025
TylerLeonhardt added a commit that referenced this issue Jan 22, 2025
@TylerLeonhardt
Layout the container on show
fef7a17 
Decent enough fix until I do the "vm scaling" fix.

Fixes #238196
@TylerLeonhardt TylerLeonhardt mentioned this issue Jan 22, 2025
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 22, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 22, 2025
legomushroom pushed a commit that referenced this issue Jan 22, 2025
@TylerLeonhardt @legomushroom
Layout the container on show (#238421)
4320ce7 
Decent enough fix until I do the "vm scaling" fix.

Fixes #238196
@bpasero bpasero added the verified Verification succeeded label Jan 28, 2025
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

Layout the container on show microsoft/vscode
2 participants
@bpasero @TylerLeonhardt