Test: Electron 34 update

[deepak1556]

Refs: #237437

• macOS @osortega
• linux @joshspicer
• windows @lszomoru

Complexity: 3

Create Issue

---

We plan to promote Electron 34 in the February 2025 milestone to insiders. The following tests cover some of the common UI bits that don't have smoke tests. You can download the nightly explorations builds from here for testing.

Testing:

• macOS:

  • Enable Native Tabs (via settings: window.nativeTabs: true)
    • Ensure native tabs are enabled in the system preferences (System Preferences > General > Prefer tabs: "always":)
    • Launch application
    • Try opening new window from either command line (code-exploration ) or from the menu entry (Cmd + Shift + N)
    • Verify new window is launched as a new tab in the active instance of the application window is focused when starting from command line
    • open the code exploration application from finder or dock
    • open external terminal
    • run code-exploration
    • make sure the new window is put to foreground
  • Font rendering with non-default family name
    • Download and install Inconsolata ExtraBold from font
    • In the editor set "editor.fontFamily": "Inconsolata ExtraBold"
    • Confirm that the font applies and compare it with insiders

• windows:

  • verify maximize and restore operations work as expected when OS task bar is auto-hidden for custom titlebar
  • Verify titlebar is not clipped off when exiting fullscreen
    • Maximize VS Code window
    • Press F11 or Ctrl+K Z twice to enter/exit full screen.
    • Verify titlebar is not cropped

• linux:

  • Verify clicking on native menu does not crash the application
    • Switch to native title bar "window.titleBarStyle": "native"
    • Click on any of the menu options File, Edit etc

• All OS:

  • Check out the electron-34.x.y branch locally and verify you can run out of sources, set a breakpoint and debug using the VS Code launch configurations and VS Code debugger

[lszomoru]

No issues found on windows 👏🏻

[osortega]

No issues on Mac!

Just as a comment, I think it would be great if we allowed opening the same workspace in a different VS Code instance, specially with multi tab now.

I think it would be really useful to be able to have the same workspace under a different working context, let's say one debugging tests and the other running the main app

[deepak1556]

Our application implementation on all platforms relies on singleton instance logic, only one instance of the application main process runs and every new instance launch will join it unless you start the new instance with a different user data directory. The tab logic is maintained in the application main process, so there is no way currently to associate windows across two different instances in the runtime.