Check error notifications on email (no storage space) #795

Author: jorikfon

src/Core/System/Notifications.php

@@ -90,19 +90,14 @@ public static function sendAdminNotification(string $subject, array $messages, b
             return;
         }
         $managedCache = $di->getShared(ManagedCacheProvider::SERVICE_NAME);
-        $cacheKey = 'sendAdminNotification:' . md5($subject . implode('', $messages));
+        $cacheKey = 'SendAdminNotification:' . md5($subject . implode('', $messages));
         $cacheTime = 3600 * 24; // 1 day
 
         // Check if the message is not urgent and has been sent recently from cache.
         if (!$urgent &&  $managedCache->has($cacheKey)) {
             return;
         }
 
-        // Check if the notification system is available (e.g., PHP Mailer is configured and working).
-        if (!self::checkConnection(self::TYPE_PHP_MAILER)) {
-            return;
-        }
-
         // Translate the subject and messages to the desired language.
         $subject = Util::translate($subject, false);
         $text = '';
@@ -197,6 +192,7 @@ public function sendMail($to, $subject, $message, string $filename = ''): bool
         }
         if (!empty($messages)) {
             SystemMessages::sysLogMsg('PHPMailer', implode(' ', $messages), LOG_ERR);
+            return false;
         }
         return true;
     }

tests/Core/Workers/Libs/WorkerPrepareAdvice/CheckStorageTest.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace MikoPBX\Tests\Core\Workers\Libs\WorkerPrepareAdvice;
+
+use MikoPBX\Core\Workers\Libs\WorkerPrepareAdvice\CheckStorage;
+use MikoPBX\Tests\Unit\AbstractUnitTest;
+
+class CheckStorageTest extends AbstractUnitTest
+{
+
+    public function testProcess()
+    {
+            $class = new CheckStorage();
+            $class->process();
+            $this->assertTrue(true);
+    }
+}

tests/Core/Workers/WorkerPrepareAdviceTest.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace MikoPBX\Tests\Core\Workers;
+
+use MikoPBX\Core\Workers\WorkerPrepareAdvice;
+use MikoPBX\Tests\Unit\AbstractUnitTest;
+
+class WorkerPrepareAdviceTest extends AbstractUnitTest
+{
+
+    public function testStart()
+    {
+        $worker = new WorkerPrepareAdvice();
+        $worker->start(['start']);
+        $this->assertTrue(true);
+    }
+}