Skip to content

issues Search Results · repo:milanvrekic/JS-humanize language:JavaScript

Filter by

10 results
 (48 ms)

10 results

inmilanvrekic/JS-humanize (press backspace or delete to remove)

milanvrekic/JS-humanize
master source code has git merging artifacts

  • aretecode
  • Opened 
    on Jul 1, 2017
  • #18

milanvrekic/JS-humanize
Have a many conflicts in js file

  • Archakov06
  • 1
  • Opened 
    on Mar 22, 2017
  • #17

milanvrekic/JS-humanize
broken cases for naturalTime

Thanks for the cool library! I found a couple things… naturalTime(time() + 3600) = in 60 minutes, should be in 1 hour naturalTime(time() + 3631) = in about 1 hours, should be in about 1 hour
  • mdarens
  • Opened 
    on Oct 15, 2012
  • #13

milanvrekic/JS-humanize
Please choose a license

This project looks useful! Can you add a license? MIT?
  • jhherren
  • 1
  • Opened 
    on Apr 16, 2012
  • #12

milanvrekic/JS-humanize
date() and time() may conflict with functions outside

The functions date(), time() and number_format() are not namespaced and may conflict with other functions outside the library. I have made a fix in 92b80b32cae3ea7f23b46a74af642fdd0c9cb96c
  • joebain
  • Opened 
    on Apr 16, 2012
  • #11

milanvrekic/JS-humanize
truncatewords() appends a space

truncatewords() appends a single space if it does not shorten the sentence. I have made a fix in ae54bd3cf19e1688fa97c96d5aa770d1c1dcfaee
  • joebain
  • 1
  • Opened 
    on Apr 16, 2012
  • #9

milanvrekic/JS-humanize
Tests should include expected results

I wanted the tests to have expected results so I could make changes against them. I don t know what the intended behaviour of each of the functions are so I could see the result and think it is ok but ...
  • joebain
  • 2
  • Opened 
    on Apr 16, 2012
  • #7

milanvrekic/JS-humanize
Wrong notation for kilo/mega/gigabyte

This is incorrect: filesizeformat (1234567890 = 1.15 Gb) Gigabyte is GB. Gigabit is Gb Correct: filesizeformat (1234567890 = 1.15 GB)
  • ryanwilliams
  • Opened 
    on Apr 16, 2012
  • #6

milanvrekic/JS-humanize
Remove comments from minified file

Without comments, the file size drops from 10kb to 5kb (or thereabouts). Why are there comments in the minified file?
  • Ricket
  • Opened 
    on Apr 16, 2012
  • #5

milanvrekic/JS-humanize
Humanize should escape HTML input

Currently Humanize doesn t do any HTML escaping; any input contains HTML fragment could get executed on the page. = Humanize.truncatechars( script alert( yo ); \/script , 30) script alert( yo ...
  • sirn
  • 1
  • Opened 
    on Apr 16, 2012
  • #2
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue search results · GitHub