From 517b59112556fac75e5e0df570c2f03b25c33c26 Mon Sep 17 00:00:00 2001 From: Haochen Wu Date: Tue, 28 Jan 2025 08:30:14 -0800 Subject: [PATCH 1/3] Implement error interface for RemoveObjectError --- api-remove.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/api-remove.go b/api-remove.go index d2e932923f..8a3e05c678 100644 --- a/api-remove.go +++ b/api-remove.go @@ -213,6 +213,10 @@ type RemoveObjectError struct { Err error } +func (err *RemoveObjectError) Error() string { + return err.Err.Error() +} + // RemoveObjectResult - container of Multi Delete S3 API result type RemoveObjectResult struct { ObjectName string From dc08cb2cce78732bc540f638ef622c44d1a74196 Mon Sep 17 00:00:00 2001 From: Haochen Wu Date: Tue, 28 Jan 2025 08:49:11 -0800 Subject: [PATCH 2/3] revise error message --- api-remove.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/api-remove.go b/api-remove.go index 8a3e05c678..2ba0ecdf92 100644 --- a/api-remove.go +++ b/api-remove.go @@ -214,6 +214,10 @@ type RemoveObjectError struct { } func (err *RemoveObjectError) Error() string { + // This should never happen as we will have a non-nil error with no underlying error. + if err.Err == nil { + return "inconsistant remove object error result" + } return err.Err.Error() } From d48691485366204b95e3cba98544e80b82ad0a41 Mon Sep 17 00:00:00 2001 From: Haochen Wu Date: Tue, 28 Jan 2025 08:59:36 -0800 Subject: [PATCH 3/3] Update api-remove.go Co-authored-by: Harshavardhana --- api-remove.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api-remove.go b/api-remove.go index 2ba0ecdf92..523431351b 100644 --- a/api-remove.go +++ b/api-remove.go @@ -216,7 +216,7 @@ type RemoveObjectError struct { func (err *RemoveObjectError) Error() string { // This should never happen as we will have a non-nil error with no underlying error. if err.Err == nil { - return "inconsistant remove object error result" + return "unexpected remove object error result" } return err.Err.Error() }