From b88c621fc5a2fb1aac3a8cd4ebb4019720448831 Mon Sep 17 00:00:00 2001 From: Erick Murillo Date: Thu, 23 Nov 2023 11:42:53 -0500 Subject: [PATCH 1/3] feat: allow to configure upload file size --- edx_sga/sga.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/edx_sga/sga.py b/edx_sga/sga.py index 9ddbbc70..d189a128 100644 --- a/edx_sga/sga.py +++ b/edx_sga/sga.py @@ -86,7 +86,14 @@ class StaffGradedAssignmentXBlock( has_score = True icon_class = "problem" - STUDENT_FILEUPLOAD_MAX_SIZE = 4 * 1000 * 1000 # 4 MB + # validate if STUDENT_FILEUPLOAD_MAX_SIZE variables is defined in config.yml + # with custom upload size, if not put the default 4mb allowed + custom_file_size = settings.STUDENT_FILEUPLOAD_MAX_SIZE + if custom_file_size: + STUDENT_FILEUPLOAD_MAX_SIZE = custom_file_size + else: + STUDENT_FILEUPLOAD_MAX_SIZE = 4 * 1000 * 1000 # 4 MB + ######### editable_fields = ("display_name", "points", "weight", "showanswer", "solution") display_name = String( From 63b94ed27871fd40ef13154f96d422817866b292 Mon Sep 17 00:00:00 2001 From: Erick Murillo Date: Thu, 23 Nov 2023 12:51:21 -0500 Subject: [PATCH 2/3] style: change variable name --- edx_sga/sga.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/edx_sga/sga.py b/edx_sga/sga.py index d189a128..d3b49267 100644 --- a/edx_sga/sga.py +++ b/edx_sga/sga.py @@ -88,9 +88,9 @@ class StaffGradedAssignmentXBlock( icon_class = "problem" # validate if STUDENT_FILEUPLOAD_MAX_SIZE variables is defined in config.yml # with custom upload size, if not put the default 4mb allowed - custom_file_size = settings.STUDENT_FILEUPLOAD_MAX_SIZE - if custom_file_size: - STUDENT_FILEUPLOAD_MAX_SIZE = custom_file_size + sga_student_file_size = settings.SGA_STUDENT_FILEUPLOAD_MAX_SIZE + if sga_student_file_size: + STUDENT_FILEUPLOAD_MAX_SIZE = sga_student_file_size else: STUDENT_FILEUPLOAD_MAX_SIZE = 4 * 1000 * 1000 # 4 MB ######### From 1243bea2d0ddf27d2fea88eee4ddb81db1209826 Mon Sep 17 00:00:00 2001 From: Erick Murillo Date: Fri, 24 Nov 2023 13:34:15 -0500 Subject: [PATCH 3/3] style: adding recommendations --- edx_sga/sga.py | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/edx_sga/sga.py b/edx_sga/sga.py index d3b49267..51f1f5a8 100644 --- a/edx_sga/sga.py +++ b/edx_sga/sga.py @@ -86,14 +86,17 @@ class StaffGradedAssignmentXBlock( has_score = True icon_class = "problem" - # validate if STUDENT_FILEUPLOAD_MAX_SIZE variables is defined in config.yml - # with custom upload size, if not put the default 4mb allowed - sga_student_file_size = settings.SGA_STUDENT_FILEUPLOAD_MAX_SIZE - if sga_student_file_size: - STUDENT_FILEUPLOAD_MAX_SIZE = sga_student_file_size - else: - STUDENT_FILEUPLOAD_MAX_SIZE = 4 * 1000 * 1000 # 4 MB - ######### + # .. setting_name: STUDENT_FILEUPLOAD_MAX_SIZE + # .. setting_default: 4 * 1000 * 1000 #4MB + # .. setting_description: Specifies the file size that the Student + # can upload via the Component. If not + # specified the default is 4MB. + # .. setting_example: { + # STUDENT_FILEUPLOAD_MAX_SIZE: 20 * 1000 * 1000 #20MB + # } + STUDENT_FILEUPLOAD_MAX_SIZE = getattr(settings, + "STUDENT_FILEUPLOAD_MAX_SIZE", + 4 * 1000 * 1000) editable_fields = ("display_name", "points", "weight", "showanswer", "solution") display_name = String(