Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass MPConfig to MixPanelAPI.getInstance() and deprecate the wrapping methods MixPanelAPI #829

Open
juliocbcotta opened this issue Feb 15, 2024 · 0 comments

Comments

@juliocbcotta
Copy link

Hello there, as we migrated to MixPanel 7.4.0, I found some issues in our code.
For instance, the serverURL that we would set in the MPConfig were not being used in the library. We were able to solve this by using the MixPanelAPI wrapping methods t o access the currently used MPConfig, but not without some pain for our devs (We used MPCofing.getInstance to set the serverURL and it was hard to detect the issue) and product folks (we lost weeks of data).

I would like to recommend allowing passing a MPConfig instance to MixPanelAPI.getInstance and deprecating the methods from MixPanelAPI that just do the forwarding to the internal instance. This would expose only one proper way of setting MPConfig values.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant