Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac: return non-zero status on errors from build_environment.sh #63

Open
rryan opened this issue Sep 1, 2018 · 2 comments
Open

Mac: return non-zero status on errors from build_environment.sh #63

rryan opened this issue Sep 1, 2018 · 2 comments

Comments

@rryan
Copy link
Member

rryan commented Sep 1, 2018

build_environment.sh can return 0 when an error occurred.

For example, if this tar invocation fails to find the file to untar.
@rryan
Copy link
Member Author

rryan commented Sep 1, 2018

Probably relevant: http://mywiki.wooledge.org/BashFAQ/105

rryan referenced this issue in mixxxdj/mixxx Sep 1, 2018
@rryan
Update Windows environment to f9779fda and macOS environment to 729dc20.
9a7149c 
- Windows environment has a taglib 1.11 fix.
- macOS environment is built with a new 10.13 build VM using the 10.13 macOS SDK.
- Update the minimum required macOS version to 10.11 in product_definition.plist.
@rryan
Copy link
Member Author

rryan commented Sep 1, 2018

My current hunch is that build_environment.sh is called as part of a pipeline, and only the last command in a pipeline returning an error triggers an exit.

scripts/macosx/build_environment.sh --dependency-cache ${RESOURCE_PATH} --name ${ENVIRONMENT_NAME} --macosx-sdk ${MACOSX_SDK} --macosx-target ${MACOSX_TARGET} ${ENABLE_ARCH} --macosx-stdlib libc++ 2>&1 | tee environment/${ENVIRONMENT_NAME}/build_environment.log

If we use set -o pipefail this should work around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rryan