-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library: add overview column #14140
base: main
Are you sure you want to change the base?
Library: add overview column #14140
Conversation
Draft until CI is happy. |
ec7c78c
to
b0038fb
Compare
b0038fb
to
fba0ecc
Compare
I took a second look and polished it a bit. |
fba0ecc
to
17243c3
Compare
passthrough entire color set to WaveformOverviewRenderer, extract what's needed
This catches all additions as before but in a simpler way. Also catches updates and removals (when the track waveform has been cleared).
17243c3
to
d644456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, not tested yet.
&TrackAnalysisScheduler::trackProgress, | ||
this, | ||
&AnalysisFeature::trackProgress, | ||
Qt::DirectConnection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use a direct connection here, this may cause headaches later. See my other comment.
@ronso0 I'm marking this PR as draft, but feel free to make active once everything is ready for another round of tests! |
Sure, I'm in no hurry here, and apparently there's not too much interest. |
I'd love to see this feature in! But equally spotted a lot of reviewer involved with this feature, and the few PR iteration so I didn't want to create a "too many cooks" problem.
Will test soon then |
Very interested in seeing this too! Gave the macOS build a quick spin and couldn't find any obvious performance regressions, seems to run pretty snappily. Interestingly, this seems to be mostly unaffected from #14089. |
I actually stumbled upon this and had a funny idea: What if sorting the overview column would sort by average energy or something? Would probably be terribly slow to compute given that waveforms are loaded lazily and introducing something like that would probably be better modeled as a separate analysis/column (#12131) 😄 |
Okay okay so I was wrong 😄 Credits go to @ninomp who did most of the work here! |
I love this feature and have been running it in my personal builds! really interested in this getting in |
Alright then, I'll squash and rebase, r just squash and merge main? (I think the last remaining review comment (Qt::DirectConnection is obsolete after merge/rebase) |
continuation of #13638
This is now based on @ninomp's initial POC commit 80d8b5f
from https://github.com/ninomp/mixxx/commits/overviewsinlibrary-rebased/
(incl. the fix from #14150 )
I addressed @Swiftb0y's review and a lot evolved anyway.
OverviewCache::prepareOverview
), though with a bit of refactoring this could be made optional<Library>
node exactly like in the waveform templates(<Visual>
widget)(I adopted the RGB simplifications made by @Nino MP, and simplified the others, too)
Ideas / Nice to have