Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tags, using tags with icons): Remove obsolet option tags_file #19

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

niclasheinz
Copy link
Contributor

@niclasheinz niclasheinz commented Feb 3, 2025

@niclasheinz niclasheinz marked this pull request as draft February 3, 2025 10:12
@niclasheinz niclasheinz marked this pull request as ready for review February 3, 2025 10:17
@squidfunk
Copy link
Member

Thanks! However, we want to keep the tags index page ☺️ We just need to remove the tags_file setting, as it's not necessary anymore when using the new tags plugin implementation, that's it! I might have not phrase that correctly.

@@ -39,8 +39,7 @@ theme:
# Plugins
plugins:
- search
- tags:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the only change necessary in both projects.

@niclasheinz
Copy link
Contributor Author

Thanks! However, we want to keep the tags index page ☺️ We just need to remove the tags_file setting, as it's not necessary anymore when using the new tags plugin implementation, that's it! I might have not phrase that correctly.

Makes sense, haven't thought about it 🤔

@niclasheinz niclasheinz requested a review from squidfunk February 3, 2025 10:35
@SerTetora
Copy link

SerTetora commented Feb 3, 2025

I checked this change and noticed that it now behaves differently: the tags at the top of any page are no longer clickable. Previously, clicking on them redirected to the index page with all tags. Is this the expected behavior?

@squidfunk
Copy link
Member

You need to add a tags index to make them clickable. If there's no tags index, there's nothing where they can link to. If you have a tags index and it still does not work, we need a minimal reproduction.

@squidfunk
Copy link
Member

LGTM!

@squidfunk squidfunk merged commit 0695270 into mkdocs-material:master Feb 3, 2025
@squidfunk
Copy link
Member

@SerTetora I just checked, our tags example still works with 9.6. – the tags link to the index.

@SerTetora
Copy link

In attached zip you still have tags_file: demo/tags.md.

@squidfunk
Copy link
Member

Oh my 🤦‍♂️ You are right, I missed that. It was missing the <!-- material/tags --> directive in tags.md. I'll send a PR.

@squidfunk
Copy link
Member

Fixed in 15c61b3 @SerTetora.

@SerTetora
Copy link

Thanks, it works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags demo is obsolete after 9.6
3 participants