-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(tags, using tags with icons): Remove obsolet option tags_file #19
Conversation
Thanks! However, we want to keep the tags index page |
@@ -39,8 +39,7 @@ theme: | |||
# Plugins | |||
plugins: | |||
- search | |||
- tags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is the only change necessary in both projects.
Makes sense, haven't thought about it 🤔 |
I checked this change and noticed that it now behaves differently: the tags at the top of any page are no longer clickable. Previously, clicking on them redirected to the index page with all tags. Is this the expected behavior? |
You need to add a tags index to make them clickable. If there's no tags index, there's nothing where they can link to. If you have a tags index and it still does not work, we need a minimal reproduction. |
LGTM! |
@SerTetora I just checked, our tags example still works with 9.6. – the tags link to the index. |
In attached zip you still have |
Oh my 🤦♂️ You are right, I missed that. It was missing the |
Fixed in 15c61b3 @SerTetora. |
Thanks, it works for me! |
As per squidfunk/mkdocs-material#7958
closes squidfunk/mkdocs-material#7958