Skip to content

Commit d6d3229

Browse files
Trottjasnell
authored andcommitted
doc: remove "feature branch" jargon
In the context of the CONTRIBUTING.md document, there is no advantage to describing the branch as a "feature branch" and the term may be confusing. Just refer to it as a branch. Context for the curious: The phrase "feature branch" in CONTIRUBTING.md confused someone I was assisting today. It occured to me that the word "feature" doesn't add anything and can be confusing. ("I'm doing a bug fix so I don't need to create a feature branch, right?") PR-URL: nodejs#8194 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 013d76c commit d6d3229

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

CONTRIBUTING.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,10 @@ does not align with the project team. Node.js has two IRC channels,
7474

7575
### Step 2: Branch
7676

77-
Create a feature branch and start hacking:
77+
Create a branch and start hacking:
7878

7979
```text
80-
$ git checkout -b my-feature-branch -t origin/master
80+
$ git checkout -b my-branch -t origin/master
8181
```
8282

8383
### Step 3: Commit
@@ -184,15 +184,15 @@ core modules.
184184
### Step 6: Push
185185

186186
```text
187-
$ git push origin my-feature-branch
187+
$ git push origin my-branch
188188
```
189189

190-
Go to https://github.com/yourusername/node and select your feature branch.
190+
Go to https://github.com/yourusername/node and select your branch.
191191
Click the 'Pull Request' button and fill out the form.
192192

193193
Pull requests are usually reviewed within a few days. If there are comments
194194
to address, apply your changes in a separate commit and push that to your
195-
feature branch. Post a comment in the pull request afterwards; GitHub does
195+
branch. Post a comment in the pull request afterwards; GitHub does
196196
not send out notifications when you add commits.
197197

198198
<a id="developers-certificate-of-origin"></a>

0 commit comments

Comments
 (0)