Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Repo: Pull in @mocha/docdash updates #5072

Open
5 tasks done
JoshuaKGoldberg opened this issue Dec 28, 2023 · 0 comments
Open
5 tasks done

🛠 Repo: Pull in @mocha/docdash updates #5072

JoshuaKGoldberg opened this issue Dec 28, 2023 · 0 comments
Labels
area: repository tooling concerning ease of contribution status: needs upstream fix defect within Mocha's dependency tree

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Dec 28, 2023

Tooling Suggestion Checklist

Overview

Right now, tooling for the docs site is built on a @mocha/docdash package:

"@mocha/docdash": "^4.0.1",

"mocha-docdash": {

That package comes from https://github.com/mochajs/docdash: a fork of the https://github.com/clenemt/docdash JSDoc 3 theme. Right now it's "54 commits ahead of, 89 commits behind clenemt/docdash:master".

The theme seems to be working fine but has a dependency on taffydb flagged by #5070. We should pull in upstream updates to the fork so that the latest clenemt/docdash fixes+features are available.

Filing this issue to track here. We'll want to also file an issue on the mochajs/docdash repo. mochajs/mocha-docdash#18

Additional Info

I suppose un-forking is theoretically doable too, but it seems like there are a lot of customizations on the Mocha side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: repository tooling concerning ease of contribution status: needs upstream fix defect within Mocha's dependency tree
Projects
None yet
Development

No branches or pull requests

1 participant