Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cvfd util bug - skip_hanging_node_check #2321

Closed
oscarfasanchez opened this issue Oct 3, 2024 · 2 comments
Closed

cvfd util bug - skip_hanging_node_check #2321

oscarfasanchez opened this issue Oct 3, 2024 · 2 comments
Labels

Comments

@oscarfasanchez
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is:
flopy.utils.cvfdutil.shapefile_to_cvfd fails when skip_hanging_node_check = True
because vertexdict_keys is not defined

To Reproduce
use
flopy.utils.cvfdutil.shapefile_to_cvfd(shp, skip_hanging_node_check = True)
or
flopy.utils.cvfdutil.to_cvfd( ... , skip_hanging_node_check = True)

Expected behavior
for meshes different from quadtree grids the use of ' skip_hanging_node_check = True ' should be allowed
currently vertexdict_keys = list(vertexdict.keys()) is defined inside this check: if not skip_hanging_node_check.
vertexdict_keys should be defined outside that IF.

Additional context
I was trying to convert a Voronoi mesh shapefile created through geopandas, but the hanging_node_check got stuck and ran forever. Then I tried to skip the check and found that problem. In theory, the bug is straightforward to fix ( I did it on my local version), but I still wonder if there may be something wrong with my mesh that makes the test last forever. any thoughts about it are welcome
Cheers

@wpbonelli
Copy link
Member

@oscarfasanchez I will close this given #2423, can you open a new issue about the check getting stuck if you're still seeing that?

@oscarfasanchez
Copy link
Contributor Author

Sure, I just did it on the issue #2427
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants