Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe use of eval #82

Open
cristianstaicu opened this issue Apr 7, 2016 · 0 comments
Open

Unsafe use of eval #82

cristianstaicu opened this issue Apr 7, 2016 · 0 comments

Comments

@cristianstaicu
Copy link

In file lib/utils/sea.js, the following use of eval is dangerous:

    if (configSource) {
        configData = eval('(' + configSource + ')');
    }

The config file can be used to inject arbitrary commands. Either validate the content of the file, use JSON.parse or use a more advanced sanitization package like:
https://www.npmjs.com/package/eval-sanitizer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant