chore(#864): change instanbul to nyc for coverage on all projects (#231)

chore(#864): change instanbul to nyc for coverage on all projects
- Added .nycrc.yml with commented out standard Mojaloop code-coverage rules
- Added Todo in README.md with note about future tests, code-coverage & CI-CD improvements
- Updated test:coverage & test:coverage-check script in package.json - removed unnecessary configs defined in the .nycrc.yml
- Minor bump to patch level to reflect dependency updates
- Fixed audit-resolve issues:

```text
--------------------------------------------------
 urijs needs your attention.

[ moderate ] Hostname spoofing via backslashes in URL
 vulnerable versions <1.19.7 found in:
 - dependencies: @mojaloop/central-services-shared>widdershins>urijs

--------------------------------------------------
 tar needs your attention.

[ high ] Arbitrary File Creation/Overwrite due to insufficient absolute path sanitization
 vulnerable versions <3.2.2 || >=4.0.0 <4.4.14 || >=5.0.0 <5.0.6 || >=6.0.0 <6.1.1 found in:
 - dependencies: @mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar
[ high ] Arbitrary File Creation/Overwrite via insufficient symlink protection due to directory cache poisoning
 vulnerable versions <3.2.3 || >=4.0.0 <4.4.15 || >=5.0.0 <5.0.7 || >=6.0.0 <6.1.2 found in:
 - dependencies: @mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar

--------------------------------------------------
 path-parse needs your attention.

[ moderate ] Regular Expression Denial of Service in path-parse
 vulnerable versions <1.0.7 found in:
 - dependencies: @mojaloop/elastic-apm-node>read-pkg-up>read-pkg>normalize-package-data>resolve>path-parse
 - dependencies: @mojaloop/elastic-apm-node>require-in-the-middle>resolve>path-parse
```

> Outcome: Fixed

```text
--------------------------------------------------
 yargs-parser needs your attention.

[ low ] Prototype Pollution
 vulnerable versions <13.1.2 || >=14.0.0 <15.0.1 || >=16.0.0 <18.1.2 found in:
 - dependencies: @mojaloop/central-services-shared>widdershins>yargs>yargs-parser
 --------------------------------------------------
 sanitize-html needs your attention.

[ moderate ] Improper Input Validation
 vulnerable versions <2.3.1 found in:
 - dependencies: @mojaloop/central-services-shared>shins>sanitize-html
[ moderate ] Improper Input Validation
 vulnerable versions <2.3.2 found in:
 - dependencies: @mojaloop/central-services-shared>shins>sanitize-html
```

> Outcome: Ignored for a week
> Impact: Minimal as this is used to render documentation end-point

Author: mdebarros

.nycrc.yml

@@ -0,0 +1,19 @@
+temp-directory: "./.nyc_output"
+check-coverage: true
+per-file: true
+lines: 90
+statements: 90
+functions: 90
+# branches: 90 ## TODO: This should be un-commented to 90 once code-coverage is improved!
+all: true
+include: [
+  "src/**/*.js"
+]
+reporter: [
+  "lcov"
+]
+exclude: [
+  "src/setup.js", # Ignoring this until there is a reason to test this file. Currently just exports the library functions.
+  "src/lib/kafka/index.js", # Ignoring this until there is a reason to test this file. Currently just exports the library functions.
+  "**/node_modules/**"
+]

README.md

@@ -2,6 +2,13 @@
 
 **EXPERIMENTAL** Event Stream Processor (ESP) for Event Stream (logs, audits, errors, trace, etc)
 
+## Todo
+
+- Improve unit tests.
+- Improve code-coverage to 90% across the board: [.nycrc.yml](./.nycrc.yml).
+- Add NPM script `test` as a `pre-commit` in the package.json.
+- Update CI-CD to include unit and code-coverage checks.
+
 ## 1. Pre-requisites
 
 ### 1.1 Elasticsearch

audit-resolve.json

@@ -175,8 +175,8 @@
     },
     "1500|@mojaloop/central-services-shared>widdershins>yargs>yargs-parser": {
       "decision": "ignore",
-      "madeAt": 1625158172377,
-      "expiresAt": 1625762958048
+      "madeAt": 1629449959242,
+      "expiresAt": 1630054673543
     },
     "1677|@mojaloop/elastic-apm-node>read-pkg-up>read-pkg>normalize-package-data>hosted-git-info": {
       "decision": "fix",
@@ -214,8 +214,8 @@
     },
     "1675|@mojaloop/central-services-shared>shins>sanitize-html": {
       "decision": "ignore",
-      "madeAt": 1625158174063,
-      "expiresAt": 1625762958048
+      "madeAt": 1629449961945,
+      "expiresAt": 1630054673543
     },
     "1676|@mojaloop/central-services-health>@mojaloop/central-services-shared>shins>sanitize-html": {
       "decision": "ignore",
@@ -224,8 +224,8 @@
     },
     "1676|@mojaloop/central-services-shared>shins>sanitize-html": {
       "decision": "ignore",
-      "madeAt": 1625158174063,
-      "expiresAt": 1625762958048
+      "madeAt": 1629449961945,
+      "expiresAt": 1630054673543
     },
     "1693|@mojaloop/central-services-health>@mojaloop/central-services-shared>shins>sanitize-html>postcss": {
       "decision": "ignore",
@@ -236,6 +236,26 @@
       "decision": "ignore",
       "madeAt": 1620986565754,
       "expiresAt": 1621591332977
+    },
+    "1766|@mojaloop/central-services-shared>widdershins>urijs": {
+      "decision": "fix",
+      "madeAt": 1629449886923
+    },
+    "1770|@mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar": {
+      "decision": "fix",
+      "madeAt": 1629449910757
+    },
+    "1771|@mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar": {
+      "decision": "fix",
+      "madeAt": 1629449910757
+    },
+    "1773|@mojaloop/elastic-apm-node>read-pkg-up>read-pkg>normalize-package-data>resolve>path-parse": {
+      "decision": "fix",
+      "madeAt": 1629449953781
+    },
+    "1773|@mojaloop/elastic-apm-node>require-in-the-middle>resolve>path-parse": {
+      "decision": "fix",
+      "madeAt": 1629449953781
     }
   },
   "rules": {},