Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using aggregate-add-third-party is not working when packaging is pom even I have set acceptPomPackaging as true #586

Open
ma345564280 opened this issue Sep 6, 2024 · 2 comments

Comments

@ma345564280
Copy link

I have set acceptPomPackaging as true, but still got the following message.

[INFO] --- license:2.4.0:aggregate-add-third-party (default-cli) @ xxxxxx ---
ERROR StatusLogger Log4j2 could not find a logging implementation. Please add log4j-core to the classpath. Using SimpleLogger to log to the console...
[INFO] The goal is skip due to packaging 'jar'
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.812 s
[INFO] Finished at: 2024-09-06T17:27:40+08:00
[INFO] ------------------------------------------------------------------------

@ma345564280
Copy link
Author

add-third-party is working

@slawekjaranowski
Copy link
Member

There is a method org.codehaus.mojo.license.AbstractLicenseMojo#checkPackaging
It is override by:

  • org.codehaus.mojo.license.AddThirdPartyMojo#checkPackaging
  • org.codehaus.mojo.license.AggregatorAddThirdPartyMojo#checkPackaging

Fixing and write tests for it should not be difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants