Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead taker #16

Open
wants to merge 1 commit into
base: v5
Choose a base branch
from
Open

Fix dead taker #16

wants to merge 1 commit into from

Conversation

ochaton
Copy link
Member

@ochaton ochaton commented Dec 16, 2020

The dead takers now alarms alive takers to reduce wait time for the next ready task. Read more info in commit message 46744c7

It is possible to replace take-* channels with fiber.cond() but it will lead to enormous fiber wakeups on high load systems

We name the client the "dead taker" if it closed connection to Tarantool
during xq:take(). Tarantool closes socket and calls callback box.session.on_disconnect
and xqueue registers that taker inside this session can't consume tasks anymore.

But, if clients sleeps for too long on the xq:take() (ex. 60 seconds) then
next taker will receive task only when new task will be produced. It is too long
to wait, so this fix implements alarm of the other takers (if there are any) in
"dead taker"
@ochaton ochaton changed the base branch from master to v5 December 16, 2020 18:50
@ochaton ochaton requested a review from Mons December 16, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant