Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate PNG icons from SVG #27

Open
gmarty opened this issue Jan 24, 2017 · 2 comments
Open

Generate PNG icons from SVG #27

gmarty opened this issue Jan 24, 2017 · 2 comments

Comments

@gmarty
Copy link
Contributor

gmarty commented Jan 24, 2017

We need a tool that generate PNG for all resolutions (1x, 1.5x, 2x, 3x and 4x) from SVG images. That will allow us to iterate faster on UI implementation.

I found rebar but it seems to be a big chunk of tools, so maybe we can just build our own script using Inkscape via the command line.

Also final PNG files must be optimised, ideally with ImageOptim. So it would be nice to add this as a step in the script.

@wilsonpage
Copy link
Collaborator

This sounds like a good idea @gmarty.

Although I don't think we should invest too much time in this. We're not loading these assets over a network, so size is not that much of a concern. The only benefit is a (probably) marginal reduction in the amount of memory/cpu consumed rendering a @2x over a @3x image.

Let's work quickly and not prematurely optimize.

@wilsonpage
Copy link
Collaborator

Comment also applies to #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants