Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inconsistent highlighting on mobile #18931

Open
17hoehbr opened this issue Oct 21, 2024 · 0 comments
Open

[Bug]: Inconsistent highlighting on mobile #18931

17hoehbr opened this issue Oct 21, 2024 · 0 comments
Labels

Comments

@17hoehbr
Copy link

Attach (recommended) or Link to PDF file

https://mozilla.github.io/pdf.js/web/viewer.html

Web browser and its version

Chromite 128

Operating system and its version

Android 14

PDF.js version

4.7.76

Is the bug present in the latest PDF.js version?

Yes

Is a browser extension

No

Steps to reproduce the problem

  1. Toggle the highlight tool on a mobile device (possibly touch devices in general)
  2. While using the highlighter, make initial touch over the text layer and swipe down
signal-2024-10-21-022022_002.mp4

What is the expected behavior?

I expected the highlighter to do free highlighting, but it seems to conflict with the text selection. On desktop browsers, making this same gesture with the mouse immediately switches to text selection mode.

Screencast_20241021_022308.webm

What went wrong?

On mobile devices, toggling text selection requires pressing and holding for a second before triggering. Therefore, nothing happens if you highlight over text.

Link to a viewer

No response

Additional context

The most straight forward solution in my opinion would be to separate the text selection highlighting and the free-handed highlighting into two separate tools.

@17hoehbr 17hoehbr changed the title [Bug]: Inconstent highlighting on mobile [Bug]: Inconsistent highlighting on mobile Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants