You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A recent change to the CLI (unrelated to the bug I'm filing) caused my CI process to fail. However, it uncovered the fact that the shane:github:src:install operation doesn't return a non-zero exit code in the event of a deployment failure.
The specific repro case is for the AEP project (you'll see that the samplecode build is broken):
It's broken because of forcedotcom/cli#1133 but the shane:github:src:install is not failing the build -- it's returning a zero exit code and allowing the next step of the build to start (which then fails because the dependencies I expected shane:github:src:install to install aren't there)
See below the exact command to run to demonstrate the problem
Expected: Expected a non-zero ERRORLEVEL after the deployment failure
Actual: ERRORLEVEL=0
A recent change to the CLI (unrelated to the bug I'm filing) caused my CI process to fail. However, it uncovered the fact that the
shane:github:src:install
operation doesn't return a non-zero exit code in the event of a deployment failure.The specific repro case is for the AEP project (you'll see that the samplecode build is broken):
https://github.com/apex-enterprise-patterns/fflib-apex-common-samplecode/actions/runs/1163965439
It's broken because of forcedotcom/cli#1133 but the
shane:github:src:install
is not failing the build -- it's returning a zero exit code and allowing the next step of the build to start (which then fails because the dependencies I expected shane:github:src:install to install aren't there)See below the exact command to run to demonstrate the problem
Expected: Expected a non-zero ERRORLEVEL after the deployment failure
Actual: ERRORLEVEL=0
I'm using the latest shane-sfdx-plugins from NPM
The text was updated successfully, but these errors were encountered: