Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut numbers no longer show conflict message #27415

Open
4 tasks done
zacjansheski opened this issue Mar 27, 2025 · 2 comments
Open
4 tasks done

Shortcut numbers no longer show conflict message #27415

zacjansheski opened this issue Mar 27, 2025 · 2 comments
Assignees
Labels
P2 Priority: Medium regression MS4 Regression on a prior release

Comments

@zacjansheski
Copy link
Contributor

zacjansheski commented Mar 27, 2025

Issue type

Choose option...

Description with steps to reproduce

  1. In Preferences > Shortcuts add a shortcut that is a number
  2. Before 4.5, a conflict message was shown "Enter TAB: fret x"
  3. Now no message is shown, when trying to use the new shortcut, duration will change

Supporting files, videos and screenshots

4.4.4

Image

4.5

Image

What is the latest version of MuseScore Studio where this issue is present?

OS: macOS 15.3, Arch.: arm64, MuseScore Studio version (64-bit): 4.5.1-250800846, revision: github-musescore-musescore-603eca8

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

MacOS15

Additional context

Pre 4.5 behavior is expected, but I believe the more common "Set Duration" conflict would be preferred

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@muse-bot muse-bot added the regression MS4 Regression on a prior release label Mar 27, 2025
@zacjansheski zacjansheski added the P2 Priority: Medium label Mar 27, 2025
@bkunda bkunda added P1 Priority: High and removed P2 Priority: Medium labels Mar 28, 2025
@bkunda
Copy link

bkunda commented Mar 31, 2025

Looks like a pre-condition for this might be that the numeric shortcut has to not already be (re-)assigned to something else.

For example, if I re-assign a command to a numeric shortcut, then the conflict label suddenly re-appears. But if it's not been re-assigned, then it won't.

Screen.Recording.2025-03-31.at.6.52.10.am.mov

I think this reduces the severity somewhat, because it's not every shortcut overwrite that's being affected here (and the action remains reversible too).

@bkunda bkunda added P2 Priority: Medium and removed P1 Priority: High labels Mar 31, 2025
@bkunda
Copy link

bkunda commented Mar 31, 2025

Investigated this a bit further. It's a tad complicated, but I can reproduce this in 4.3.2, and @mathesoncalum can reproduce something similar in 4.2.

If you try to assign a numerical key shortcut to a command that already contains a shortcut assignment, AND that numerical key shortcut is already assigned to another command, then the conflicting shortcut message will show.

If, however, you try to assign such a numerical key shortcut to a command that has no shortcut assignment, then no conflicting shortcut message will show.

It is, however, possible to still trigger the conflicting shortcut message in this situation by re-assigning the numerical key shortcut to a command where the conflicting shortcut message does show. If this is done first, then that same numerical shortcut can be re-assigned to a command that has no shortcut assignment, where the conflicting shortcut message will now show as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority: Medium regression MS4 Regression on a prior release
Projects
Status: Next one or two releases
Development

No branches or pull requests

4 participants