fix: use correct chunk size default unit #118
Merged
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjl-mux
force-pushed
the
ajlb/fix/use-correct-default-for-gcp
branch
2 times, most recently
from
5dd3738 to
4ddb9ab
Compare
andrewjl-mux
commented
Nov 27, 2024
| @@ -307,7 +322,7 @@ extension Measurement where UnitType == UnitInformationStorage { | |||
| public static var defaultDirectUploadChunkSize: Self { | |||
| Measurement( | |||
| value: 8, | |||
| unit: .megabytes | |||
| unit: .mebibytes | |||
There was a problem hiding this comment.
Unit change here
andrewjl-mux
force-pushed
the
ajlb/fix/use-correct-default-for-gcp
branch
from
bf6a761 to
8081a24
Compare
Merged
andrewjl-mux
added a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GCP docs. Fixes #115.