Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very spammy DISCO messages when no direct connection is established #3131

Open
flub opened this issue Jan 14, 2025 · 0 comments
Open

Very spammy DISCO messages when no direct connection is established #3131

flub opened this issue Jan 14, 2025 · 0 comments
Labels
bug Something isn't working c-iroh hole punching
Milestone

Comments

@flub
Copy link
Contributor

flub commented Jan 14, 2025

When testing in relay-only mode we end up with very spammy DISCO messages blowing up the datagram sends queues in the magicsocket:

On each datagram being sent the NodeState::get_send_addrs discovers it has no UDP information so it requests a "full ping" which consists of pinging all the addresses, including the relay one as well as sending a call-me-maybe. So that is two extra DISCO messages being queued to send over the relay on top of the datagram being sent.

I'm not sure if this is only an artifact of the relay-only debugging mode or would also occur if hole punching fails. The relay-only debugging mode is far from perfect and does a lot of things an actual relay-only mode should not do.

@flub flub added bug Something isn't working hole punching c-iroh labels Jan 14, 2025
@flub flub added this to iroh Jan 14, 2025
@matheus23 matheus23 added this to the v1.0.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c-iroh hole punching
Projects
Status: No status
Development

No branches or pull requests

2 participants