Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka-python missing from requirements.txt #308

Open
grepory opened this issue Oct 22, 2019 · 1 comment
Open

kafka-python missing from requirements.txt #308

grepory opened this issue Oct 22, 2019 · 1 comment

Comments

@grepory
Copy link

grepory commented Oct 22, 2019

The official and locally built napalm-logs Docker container I made don't support the kafka transport. Upon inspection, I realized that kafka-python is missing from requirements.txt--so it will never make it into the container. I've fixed this in my fork, but wanted to know if that was deliberately left out or if there's a way to get it into the Docker container other than this that I'm not aware of.

@mirceaulinic
Copy link
Member

mirceaulinic commented Nov 28, 2019

Hey @grepory - sorry for late reply here. Kafka is one of the optional publishers, meaning that you need to manage the dependencies yourself. I had the feeling that this is already mentioned in the documentation, but it's not unfortunately: https://napalm-logs.com/en/latest/publisher/kafka.html 😞 So this should be corrected.
That said, we can add a small feature so when installing napalm-logs you can install it, e.g., pip install napalm-logs[kafka] to pull all the dependencies for you. I have mixed feelings about this sort of tricks as they can lead to confusion, and I think I prefer to let the user decide what's best for them to install. How'd you find that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants