For status checks, return DRMAA_ERRNO_DRM_COMMUNICATION_FAILURE when

natefoo · natefoo · commit 83fc28856134 · 2017-11-16T00:42:54.000-05:00
slurm communication problems are encountered. Thanks @tbooth!
diff --git a/slurm_drmaa/job.c b/slurm_drmaa/job.c
@@ -130,6 +130,9 @@ slurmdrmaa_job_update_status( fsd_job_t *self )
 
 			if (_slurm_errno == ESLURM_INVALID_JOB_ID) {
 				self->on_missing(self);
+			} else if (_slurm_errno == SLURM_PROTOCOL_SOCKET_IMPL_TIMEOUT ||
+				   _slurm_errno == SLURMCTLD_COMMUNICATIONS_CONNECTION_ERROR) {
+				fsd_exc_raise_fmt(FSD_ERRNO_DRM_COMMUNICATION_FAILURE,"slurm_load_jobs error: %s,job_id: %s", slurm_strerror(_slurm_errno), self->job_id);
 			} else {
 				fsd_exc_raise_fmt(FSD_ERRNO_INTERNAL_ERROR,"slurm_load_jobs error: %s,job_id: %s", slurm_strerror(slurm_get_errno()), self->job_id);
 			}

Original file line number	Diff line number	Diff line change
`@@ -130,6 +130,9 @@ slurmdrmaa_job_update_status( fsd_job_t *self )`
`130`	`130`
`131`	`131`	`if (_slurm_errno == ESLURM_INVALID_JOB_ID) {`
`132`	`132`	`self->on_missing(self);`
	`133`	`+ } else if (_slurm_errno == SLURM_PROTOCOL_SOCKET_IMPL_TIMEOUT \|\|`
	`134`	`+ _slurm_errno == SLURMCTLD_COMMUNICATIONS_CONNECTION_ERROR) {`
	`135`	`+ fsd_exc_raise_fmt(FSD_ERRNO_DRM_COMMUNICATION_FAILURE,"slurm_load_jobs error: %s,job_id: %s", slurm_strerror(_slurm_errno), self->job_id);`
`133`	`136`	`} else {`
`134`	`137`	`fsd_exc_raise_fmt(FSD_ERRNO_INTERNAL_ERROR,"slurm_load_jobs error: %s,job_id: %s", slurm_strerror(slurm_get_errno()), self->job_id);`
`135`	`138`	`}`