Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move riscv64 crt0 to objcopy #11

Closed
gmbr3 opened this issue May 7, 2024 · 3 comments
Closed

Move riscv64 crt0 to objcopy #11

gmbr3 opened this issue May 7, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone
4.0.0

Comments

@gmbr3
Copy link
Collaborator

gmbr3 commented May 7, 2024

gnu-efi should move the crt0 for riscv64 to the objcopy type instead of the 'manual symbols' type as we now have efi-app-riscv64.
We should keep the original and rename it and allow detection of what is the default to prevent mix-ups like ARM64.

Relates to rhboot/shim#641
@ncroxon
Copy link
Owner

ncroxon commented May 8, 2024

Agreed.

gmbr3 added a commit to gmbr3/gnu-efi that referenced this issue Jun 11, 2024
@gmbr3
Move riscv64 default to objcopy
7e123a3 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
gmbr3 added a commit to gmbr3/gnu-efi that referenced this issue Jun 11, 2024
@gmbr3
Move riscv64 default to objcopy
74b9990 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
gmbr3 added a commit to gmbr3/gnu-efi that referenced this issue Jun 11, 2024
@gmbr3
Move riscv64 default to objcopy
eecb589 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
jmontleon pushed a commit to jmontleon/gnu-efi that referenced this issue Jun 24, 2024
@gmbr3 @jmontleon
Move riscv64 default to objcopy
7e7bc53 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
(cherry picked from commit eecb589)
@jmontleon jmontleon mentioned this issue Jun 24, 2024
Open
gmbr3 added a commit to gmbr3/gnu-efi that referenced this issue Jun 24, 2024
@gmbr3
Move riscv64 default to objcopy
11a63dd 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
gmbr3 added a commit to gmbr3/gnu-efi that referenced this issue Jun 24, 2024
@gmbr3
Move riscv64 default to objcopy
25f61c3 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
gmbr3 added a commit to gmbr3/gnu-efi that referenced this issue Jun 24, 2024
@gmbr3
Move riscv64 default to objcopy
2d25a81 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
gmbr3 added a commit to gmbr3/gnu-efi that referenced this issue Jun 24, 2024
@gmbr3
Move riscv64 default to objcopy
fd4d670 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
gmbr3 added a commit to gmbr3/gnu-efi that referenced this issue Jun 24, 2024
@gmbr3
Move riscv64 default to objcopy
aa5aa91 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
gmbr3 added a commit to gmbr3/gnu-efi that referenced this issue Jun 24, 2024
@gmbr3
Move riscv64 default to objcopy
c8dafe4 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
gmbr3 added a commit to gmbr3/gnu-efi that referenced this issue Jun 24, 2024
@gmbr3
Move riscv64 default to objcopy
72678a9 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
@jmontleon
Copy link

jmontleon commented Jun 27, 2024 •
edited
Loading

@gmbr3 It looks like this may still be a work in progress, based on additional commits since I tried, but I wanted to give some feedback that I was able to use it to build rhboot/shim and boot both a VisionFive 2 and a libvirt VM into Fedora 40 using your work along with the linked PR.

@gmbr3
Copy link
Collaborator Author

gmbr3 commented Jun 30, 2024

@gmbr3 It looks like this may still be a work in progress, based on additional commits since I tried, but I wanted to give some feedback that I was able to use it to build rhboot/shim and boot both a VisionFive 2 and a libvirt VM into Fedora 40 using your work along with the linked PR.

Thanks for your positive feedback
Technically WIP until I get everything I want included done but glad the RISCV64 part works

gmbr3 added a commit to gmbr3/gnu-efi that referenced this issue Jul 4, 2024
@gmbr3
Move riscv64 default to objcopy
da23914 
Fixes ncroxon#11

Signed-off-by: Callum Farmer <[email protected]>
@ncroxon ncroxon closed this as completed in 353984b Jul 7, 2024
@gmbr3 gmbr3 added the enhancement New feature or request label Nov 22, 2024
@gmbr3 gmbr3 added this to the 4.0.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@jmontleon @gmbr3 @ncroxon