Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated searching for ndless.cfg is extremely slow if you have a lot of documents #120

Closed
pbfy0 opened this issue Apr 29, 2018 · 2 comments · May be fixed by #123
Closed

Repeated searching for ndless.cfg is extremely slow if you have a lot of documents #120

pbfy0 opened this issue Apr 29, 2018 · 2 comments · May be fixed by #123

Comments

@pbfy0
Copy link
Contributor

pbfy0 commented Apr 29, 2018

cfg_locate_cfg_file means that to open a document with an association, ndless has to (very slowly) trawl through the entire filesystem. This adds a delay of 10-15 seconds on my calculator with a pretty full internal filesystem. I'm not clear on why it has to search the entire filesystem for a file that's supposed to be in a specific place. If it's for compatibility with Hide Manager, maybe there should be an API for changing the ndless folder location. At the minimum, can we cache the location after finding it the first time? I'm willing to implement any of these changes, but I want to understand why it's the way it is now before I start changing things.

@Vogtinator
Copy link
Contributor

I'm not sure either. I'd say that always checking for get_documents_dir()/ndless/ndless.cfg is ok.

@pbfy0 pbfy0 mentioned this issue May 13, 2018
@Vogtinator
Copy link
Contributor

Indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants