Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't style #10

Open
1 task done
PerchunPak opened this issue Feb 9, 2025 · 3 comments
Open
1 task done

Don't style #10

PerchunPak opened this issue Feb 9, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@PerchunPak
Copy link
Contributor

Clear and concise description of the problem

This is a great library! But please don't make assumptions about styling components.

As an example, this line breaks my page layout

.infinite-loader-wrapper {
width: 100%;

Suggested solution

Do not apply any styles, let user figure it out. Also, would be great to expose class prop for wrapper elements

Alternative

No response

Additional context

No response

Validations

  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@PerchunPak PerchunPak added the enhancement New feature or request label Feb 9, 2025
@PerchunPak
Copy link
Contributor Author

And yes, I know I can use !important to fix everything, but this is IMO an antipattern and should be avoidable where possible

@ndom91
Copy link
Owner

ndom91 commented Feb 12, 2025

Yeah good catch, you shouldn't need to!importsnt override anything here.

That width:100% you pointed out though, should make the infinite load wrapper fill it's container, is that not the case in your design? What if you just wrapped this component in another div in your application and constrain that divs size?

@PerchunPak
Copy link
Contributor Author

I used width: auto !important to manage my width

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants