Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Run linters in CI #24

Open
LeSpocky opened this issue Mar 5, 2025 · 1 comment
Open

Question: Run linters in CI #24

LeSpocky opened this issue Mar 5, 2025 · 1 comment
Labels
question Further information is requested

Comments

@LeSpocky
Copy link
Member

LeSpocky commented Mar 5, 2025

Different linters would be available for this project, e.g. for reuse or for ansible itself. Do we want to run those through GitHub actions?

@LeSpocky LeSpocky added the question Further information is requested label Mar 5, 2025
@penguineer
Copy link
Member

It would make sense to run them as CI verification, similar to workflows like https://github.com/penguineer/synctexng-rmq-server/blob/main/.github/workflows/maven-test.yml

This way a PR is not released for merge unless the linter is fine. An important prerequisite is that the introduction of this action also cleans all linter warnings that would lead to a PR being rejected. Otherwise contributors are forced to clean up code they didn't change.

Also a good documentation on how to invoke the linter locally would be helpful.

(I am not a fan of pre-commit hooks, as they break the commit-often paradigm, but I also don't want to wait for actions to finish just to get all linter warnings fixed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants