Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Name and Property on licenseKeySecret #203

Open
pragmaticivan opened this issue Jan 24, 2025 · 0 comments
Open

Support Name and Property on licenseKeySecret #203

pragmaticivan opened this issue Jan 24, 2025 · 0 comments

Comments

@pragmaticivan
Copy link

pragmaticivan commented Jan 24, 2025

Summary

Given a namespace have a secret newrelic-credentials I want to be able to use this secret but pull the ingestion key from the property ingest-key inside the secret.

This is useful for multi-tenant environments where each namespace has a set of Secrets they can use provided by a platform engineering team.

Desired Behavior

apiVersion: newrelic.com/v1alpha2
kind: Instrumentation
metadata:
  labels:
    app.kubernetes.io/name: newrelic-instrumentation-nodejs
  name: newrelic-instrumentation-nodejs
spec:
  agent:
    language: nodejs
    image: newrelic/newrelic-node-init:12
  podLabelSelector:
    matchExpressions:
    - key: app.newrelic.instrumentation
      operator: In
      values: [nodejs]
  licenseKeySecret: 
     name: newrelic-creds
     key: ingest-key

Possible Solution

Support name and key in the CRD, but make key optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant