Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with preview generation on "ProPhoto RGB" JPEGs #201

Closed
t3dc opened this issue Jul 25, 2020 · 5 comments
Closed

Problem with preview generation on "ProPhoto RGB" JPEGs #201

t3dc opened this issue Jul 25, 2020 · 5 comments

Comments

@t3dc
Copy link

t3dc commented Jul 25, 2020

Hey folks,

This is a cross-post of an issue I opened over on the nextcloud support channel but I thought this might be a better place to post and get an answer.

I have a series of photos an event photographer is providing me that I would like to share with family using our family nextcloud. Here's the problem, the previews get the colors wrong:
Screenshot 2020-07-24 at 08 50 04

As you can see in the example above, skin tones move from normal and healthy looking to something like the zombie apocalypse.

The source jpegs display beautifully on my computer after syncing from NextCloud, but the previews all look like they do above. I've deleted and recreated all of the previews at command-line (using previewgenerator) and I've followed the guides for changing NextCloud's default previewing behavior. The results remain as above. If I upload a jpeg from my camera, it looks fine. Only jpegs coming from the photographer have an issue. That's what got me looking at color profiles.

The photog is using "ProPhoto RGB" as her colorspace. When I create jpegs, I'm using "sRGB." I can convert her photos from "ProPhoto RGB" to "sRGB" and they preview properly -- but of course there is some generation loss.

Can anyone help me figure out how to generate proper previews from the ProPhoto RGB files? Or even manually replace previews with a batch export from some other program?

Thanks!

@ShaunCurrier
Copy link

Definitely smells like what would happen if the preview generator doesn't respect the color profile when generating the preview. Instead, it seems like it's reading the image data naively and treating it as though it is sRGB. In my experience, when non-color-space-aware apps open large color space images the result is colors that look washed-out and lack saturation. Just like what you show.

Sorry, I can't propose a solution, but thought +1'ing the problem might help eventually.

@t3dc
Copy link
Author

t3dc commented Feb 1, 2022 via email

@st3iny
Copy link
Member

st3iny commented Feb 1, 2022

This seems to be an issue with gd and more specifically libgd. There is already an open ticket about this issue at libgd/libgd#136.

Sadly, there is not much I can do right now. As long as the server code is using gd to generate previews we are stuck with this issue.

@t3dc
Copy link
Author

t3dc commented Feb 1, 2022 via email

@joshtrichards
Copy link
Member

Duplicate of nextcloud/server#22951

@joshtrichards joshtrichards marked this as a duplicate of nextcloud/server#22951 Mar 30, 2024
@joshtrichards joshtrichards closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants