Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud Hub 10 (v 31.0.0) "Allow download and sync" feature (Files) : bugs or features ? #51129

Open
Jerome-Herbinet opened this issue Feb 28, 2025 · 8 comments

Comments

@Jerome-Herbinet
Copy link
Member

Jerome-Herbinet commented Feb 28, 2025

Concerning "allow download and sync" : I would like to be sure to understand how it works :

When unchecked, an internal share recipient (user), should not be able to download and sync from :

  • smartphone app
  • computer (from the file explorer via desktop sync)
  • web UI

Is that right ?

I noticed that when option is unchecked :

  • Mobile app (android) : I can't sync (but IMO the "sync" action button should not appear because it creates confusion), AND I can't export (but IMO the "export" action button should not appear because it creates confusion)
  • Computer's file manager (desktop sync) : I can sync the shared folder anyway (not tested for a single shared file) ... IMO, shared folder should not appear in the settings window of the desktop sync app (or it should be greyed out)
  • Web UI : I can't download from Files or "save as" from Collabora ... but I can "save as" PDF, etc... from "Files" (new Hub 10 feature)

What do you think ? Bug or feature ?

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.
@Jerome-Herbinet
Copy link
Member Author

@jancborchardt

@susnux
Copy link
Contributor

susnux commented Feb 28, 2025

See also #46256


In general it does forbid any API that offers download (including WebDAV) - so only in-browser viewing is possible with apps that support view without download (e.g. Collabora but not the files pdf viewer as it basically downloads the file and let the browser display it).

@Jerome-Herbinet
Copy link
Member Author

See also #46256

In general it does forbid any API that offers download (including WebDAV) - so only in-browser viewing is possible with apps that support view without download (e.g. Collabora but not the files pdf viewer as it basically downloads the file and let the browser display it).

@susnux, OK, so, based on what you said :

  • Computer (desktop client) : I should not be able to sync the folder, despite I didn't uncheck it in the desktop client settings. I conclude that this is a bug. Also, if by chance the sender of the share had forgotten to uncheck the box and it is necessary to do so a few moments later, and in the meantime the recipient has synchronised the shared folder (or file), unchecking the option will deactivate synchronisation of the items concerned and remove them from the recipient's computer the next time they are synchronised.
  • Mobile app (at least the android version because I didn't test the iOS one) : It fits what you explained BUT the fact that the export / download / sync menu items still appear is a real problem. This will be considered as a bug (the recipient of the share is not supposed to know how the share was configured by the sender). This will generate support tickets, wasted time for both the sender and the recipient, and frustration. In my opinion, Nextcloud should remove those menu entries in the UI in order to make the UX "clean".
  • Web UI : When the option is unchecked, I can't download from "Files" (meat balls) or "save as" from Collabora ... but I can "save as" PDF, etc... from "Files" (new Hub 10 feature). To be consistent, we should not be able to "Save as" when the option is unchecked.

@jancborchardt
Copy link
Member

@sorbaugh @AndyScherzinger would indeed be good to bring this in line with expectations. Probably an item for next planning?

@susnux
Copy link
Contributor

susnux commented Mar 3, 2025

It fits what you explained BUT the fact that the export / download / sync menu items still appear is a real problem.

Yes should then be reported to the Android client issue tracker.

Computer's file manager (desktop sync) : I can sync the shared folder anyway (not tested for a single shared file) ... IMO, shared folder should not appear in the settings window of the desktop sync app (or it should be greyed out)

So it allows to select the folder for sync? Thats a bug and should be reported to the desktop client.
But it should not download the files as all APIs should be blocked. Are they?

Web UI : When the option is unchecked, I can't download from "Files" (meat balls) or "save as" from Collabora ... but I can "save as" PDF, etc... from "Files" (new Hub 10 feature). To be consistent, we should not be able to "Save as" when the option is unchecked.

Yes thats a bug in 31.

@susnux
Copy link
Contributor

susnux commented Mar 3, 2025

Probably an item for next planning?

I hope #46256 is also part of it as it basically decides how we can proceed here.

@Jerome-Herbinet
Copy link
Member Author

I notice that the "Allow download and sync" option is also available in NC 30. I add the appropriate tag.

@susnux
Copy link
Contributor

susnux commented Mar 3, 2025

I notice that the "Allow download and sync" option is also available in NC 30. I add the appropriate tag.

It is also available in previous nextcloud versions, we just renamed it from "allow download" in 30: #47198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants