Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark extra apps in non-writable folders as non-removeable and non-updateable #51183

Open
boomer41 opened this issue Mar 2, 2025 · 2 comments
Labels

Comments

@boomer41
Copy link

boomer41 commented Mar 2, 2025

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
I am building my own docker image of Nextcloud, extending the image from github.com/nextcloud/docker.

I am adding extra apps in a new folder additional_bundled_apps and I have added this folder in the configuration like this:

<?php
$CONFIG = array (
  'apps_paths' => array (
      0 => array (
              'path'     => OC::$SERVERROOT.'/apps',
              'url'      => '/apps',
              'writable' => false,
      ),
      1 => array (
              'path'     => OC::$SERVERROOT.'/additional_bundled_apps',
              'url'      => '/additional_bundled_apps',
              'writable' => false,
      ),
      2 => array (
              'path'     => OC::$SERVERROOT.'/custom_apps',
              'url'      => '/custom_apps',
              'writable' => true,
      ),
  ),
);

As you can see, I marked the new folder as non-writable. However, the App Store shows that I could uninstall the app.
Clicking on that button removes the entry temporarily, but upon pressing F5 the entry is back in the same state as before.
So that button click is a noop, which makes sense, because I marked that app path as non-writable.

However, apps residing in a non-writable folder should also be marked as non-removable to not even show that message. Also, updates should IMO be disabled because the server cannot write to that path.

Describe the solution you'd like
Apps residing in non-writable apps folders should also be marked and treated as non-removable and non-updatable.

Describe alternatives you've considered
We considered not bundling those apps, but then we'd have to rely on an internet connection when updating or bootstraping an instance.

Additional context
Running NC 30.0.0

@boomer41 boomer41 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Mar 2, 2025
@susnux
Copy link
Contributor

susnux commented Mar 2, 2025

bundled is something different, that are the core apps of Nextcloud included in the release and not published on the appstore.

I think this rather are two bugs:

  • apps in read-only app directories should not be listed as remove-able
  • apps in read-only app directories should not be able to update
    • (but probably still show there is an update if the appstore is enabled so you get the notification and can do it manually)

@boomer41
Copy link
Author

boomer41 commented Mar 2, 2025

I agree, the term "bundled" is a bit misleading on my side.
Your approach is exactly what I was asking. :)

EDIT: I have updated the description above.

@boomer41 boomer41 changed the title Mark extra apps in non-writable folders as bundled Mark extra apps in non-writable folders as non-removeable and non-updateable Mar 2, 2025
@susnux susnux added bug 1. to develop Accepted and waiting to be taken care of feature: apps management and removed enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants