Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - fullWidth prop of Select component does nothing #3745

Closed
paveldpetrov opened this issue Sep 13, 2024 · 4 comments · Fixed by #3768
Closed

[BUG] - fullWidth prop of Select component does nothing #3745

paveldpetrov opened this issue Sep 13, 2024 · 4 comments · Fixed by #3768
Assignees
Labels
📦 Scope : Components Related to the components 🐛 Type: Bug Something isn't working

Comments

@paveldpetrov
Copy link

paveldpetrov commented Sep 13, 2024

NextUI Version

2.4.6

Describe the bug

In the docs of the Select component it is said the following:
fullWidth Whether the select should take up the width of its parent. and it defaults to true.
However, when I pass fullWidth={false}, nothing changes.

Your Example Website or App

https://codesandbox.io/p/devbox/little-river-rnm39w

Steps to Reproduce the Bug or Issue

  1. Add a simple Select inside some wrapper with fixed width.
  2. Set fullWidth prop to false
  3. Observe that the Select still takes the full width of its parent.

Expected behavior

I would expect setting fullWidth to false to remove the w-full className from the base slot.

Screenshots or Videos

No response

Operating System Version

Windows

Browser

Chrome

Copy link

linear bot commented Sep 13, 2024

@wingkwong wingkwong added 🐛 Type: Bug Something isn't working 📦 Scope : Components Related to the components labels Sep 13, 2024
@wingkwong
Copy link
Member

some preliminary findings:

  • by default, there is w-full on base, mainWrapper etc
  • setting fullWidth to false does not override the default variant (true)
  • may double check with other components as well

@macci001
Copy link
Contributor

Can I work on this? @wingkwong

@wingkwong
Copy link
Member

@macci001 Go ahead.

fwcd added a commit to ProjectLighthouseCAU/luna that referenced this issue Oct 7, 2024
Currently it doesn't seem to do anything though, likely due to
nextui-org/nextui#3745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Scope : Components Related to the components 🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants