Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic for the methylseq pipeline #395

Closed
Shaun-Regenbaum opened this issue Apr 2, 2024 · 18 comments · Fixed by #438
Closed

Schematic for the methylseq pipeline #395

Shaun-Regenbaum opened this issue Apr 2, 2024 · 18 comments · Fixed by #438
Assignees
Labels
enhancement New feature or request

Comments

@Shaun-Regenbaum
Copy link
Contributor

Description of feature

I know there is a standard practice for making the schematics for the different nf-core pipelines. I just wanted to know the status of this pipeline's diagram.

Is anyone working on it? If not, I'd be glad to make it.

@Shaun-Regenbaum Shaun-Regenbaum added the enhancement New feature or request label Apr 2, 2024
@Shaun-Regenbaum Shaun-Regenbaum added this to the 2.7.0 milestone Apr 2, 2024
@Shaun-Regenbaum Shaun-Regenbaum self-assigned this Apr 2, 2024
@sateeshperi
Copy link
Contributor

@Shaun-Regenbaum would you still be interested in making a metro map for methylseq ?

@Shaun-Regenbaum
Copy link
Contributor Author

I would be, I'm traveling at the moment but in a few weeks?

@sateeshperi
Copy link
Contributor

We are planning for a release in next few weeks. would be cool to have a metro map for the release if we can. Thanks a lot! much appreciated.

@sateeshperi
Copy link
Contributor

plz reach out on the slack channel if you need any help

@sateeshperi
Copy link
Contributor

related #383

@matrulda if you could help in any way for creating the metro maps, that would be much appreciated!

@sateeshperi
Copy link
Contributor

hey @Shaun-Regenbaum @matrulda

any chance you got to work on the metro map ?

@Shaun-Regenbaum
Copy link
Contributor Author

Minor update:
Image
@sateeshperi

@Shaun-Regenbaum
Copy link
Contributor Author

Let me know if there are any changes, otherwise I can create the appropriate svg and png files.

@sateeshperi
Copy link
Contributor

minor- Qualimap is spelled wrong

but, this is looking real good

looping @ewels @maxulysse @edmundmiller @FelixKrueger for review & suggestions

@nf-core nf-core deleted a comment from Shaun-Regenbaum Oct 20, 2024
@sateeshperi
Copy link
Contributor

the bwameth & bismark nodes can be called Bwameth Align & Bismark Align I think....thoughts ?

Also we do have bismark_hisat option, wonder if that should be represented somehow ?

@Shaun-Regenbaum
Copy link
Contributor Author

I am fine with that, in regards to hisat, if we are going to include three pipelines, we should add it to the steps: Image

Otherwise, if we are treating it as an optional parameter, we should not include it in my opinion. Like if we want to include it we should have some documentation on when you want to use hisat vs bowtie in this context.

@sateeshperi
Copy link
Contributor

@sateeshperi
Copy link
Contributor

I added you the the methylseq channel in nf-core slack if you don't mind we can carry our conversation there ?

@sateeshperi sateeshperi removed this from the 2.7.0 milestone Oct 22, 2024
@sateeshperi
Copy link
Contributor

Hi could you share the map files in the slack thread after your edits when you get a chance. Thanks a lot!

@Shaun-Regenbaum
Copy link
Contributor Author

@Shaun-Regenbaum
Copy link
Contributor Author

Going off steps:
Bismark/Bismark_Hisat:
PREPARE_GENOME:BISMARK_GENOMEPREPARATION
METHYLSEQ:CAT_FASTQ
METHYLSEQ:FASTQC
METHYLSEQ:TRIMGALORE
METHYLSEQ:BISMARK:BISMARK_ALIGN
METHYLSEQ:BISMARK:SAMTOOLS_SORT_ALIGNED
METHYLSEQ:BISMARK:BISMARK_DEDUPLICATE
METHYLSEQ:BISMARK:BISMARK_METHYLATIONEXTRACTOR
METHYLSEQ:BISMARK:BISMARK_REPORT
METHYLSEQ:BISMARK:BISMARK_SUMMARY
METHYLSEQ:BISMARK:SAMTOOLS_SORT_DEDUPLICATED
METHYLSEQ:BISMARK:SAMTOOLS_INDEX_DEDUPLICATED
METHYLSEQ:QUALIMAP_BAMQC
METHYLSEQ:PRESEQ_LCEXTRAP
METHYLSEQ:MULTIQC
Bwameth:
PREPARE_GENOME:BWAMETH_INDEX
METHYLSEQ:CAT_FASTQ
METHYLSEQ:FASTQC
METHYLSEQ:TRIMGALORE
METHYLSEQ:BWAMETH:BWAMETH_ALIGN
METHYLSEQ:BWAMETH:SAMTOOLS_SORT
METHYLSEQ:BWAMETH:SAMTOOLS_INDEX_ALIGNMENTS
METHYLSEQ:BWAMETH:SAMTOOLS_FLAGSTAT
METHYLSEQ:BWAMETH:SAMTOOLS_STATS
METHYLSEQ:BWAMETH:PICARD_MARKDUPLICATES
METHYLSEQ:BWAMETH:SAMTOOLS_INDEX_DEDUPLICATED
METHYLSEQ:BWAMETH:METHYLDACKEL_EXTRACT
METHYLSEQ:BWAMETH:METHYLDACKEL_MBIAS
METHYLSEQ:QUALIMAP_BAMQC
METHYLSEQ:PRESEQ_LCEXTRAP
METHYLSEQ:MULTIQC (edited)

@Shaun-Regenbaum
Copy link
Contributor Author

Final update:

Image

Addressed in merge #437

@matrulda
Copy link

related #383

@matrulda if you could help in any way for creating the metro maps, that would be much appreciated!

Sorry for not replying earlier! I've been kind of swamped. I think @Shaun-Regenbaum did an excellent job, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants