Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bwameth pipeline skipping all bwameth steps when --fasta, --fasta_index, and --bwa_meth_index are provided. #396

Closed
drothen15 opened this issue Apr 5, 2024 · 4 comments · Fixed by #414
Labels
bug Something isn't working
Milestone

Comments

@drothen15
Copy link

Description of the bug

I have previously processed the GRCh38 genome with bwameth for a different pipeline that I'm trying to compare with the nf-core. So I provide the following with the input command:
--fasta
--fasta_index
--bwa_meth_index

However, everytime I do this the pipeline just skips all the bwameth steps in the pipeline and then completes without error (screenshot).

Screenshot 2024-04-05 at 12 15 39 PM

Command used and terminal output

nextflow run /shared-storage/data/ngs/methylseq-test --input SampleSheet.csv --outdir /shared-storage/home/drothenheber/meth_testing/20240404_nf-core_bwameth --em_seq --comprehensive --aligner bwameth -profile apptainer --fasta test.fa --fasta_index test.fa.fai --bwa_meth_index /path/to/bwameth/indices/

Relevant files

nextflow.log

System information

Nextflow version: 23.10.1
Hardware: HPC
Executor: slurm
Container engine: apptainer
OS: Linux
MethylSeq version: 2.6.0

@drothen15 drothen15 added the bug Something isn't working label Apr 5, 2024
@npatel-ah
Copy link

I created the bismark index and kept the reference file within the folder ( not soft link), then re-ran it using --bismark_index and that seems to solve it for now.

@maxulysse
Copy link
Member

should have been fixed by #403

@JihedC
Copy link

JihedC commented Aug 21, 2024

I created the bismark index and kept the reference file within the folder ( not soft link), then re-ran it using --bismark_index and that seems to solve it for now.

Hi,

I am having the same issue and am not sure that #403 fixed it. What do you mean with adding the bismark index, do you provide the path to the bismark index after --bismark_index or do you have to place the index somewhere specific?

thanks in advance for your help!

@yinyeya
Copy link

yinyeya commented Aug 28, 2024

I have the exact same issue and when going through the codes, I notice the following scripts in the local module "prepare_genome.nf",

    // Aligner: bwameth
    else if ( params.aligner == 'bwameth' ){

        /*
         * Generate bwameth index if not supplied
         */
        if (params.bwa_meth_index) {
            if (params.bwa_meth_index.endsWith('.tar.gz')) {
                ch_bismark_index = UNTAR ( [ [:], file(params.bwa_meth_index) ] ).untar.map { it[1] }
            } else {
                ch_bismark_index = Channel.value(file(params.bwa_meth_index))
            }
        } else {
            BWAMETH_INDEX(ch_fasta)
            ch_bwameth_index = BWAMETH_INDEX.out.index
            ch_versions = ch_versions.mix(BWAMETH_INDEX.out.versions)
        }

When providing bwameth index, either compressed or uncompressed format, it will pass to ch_bismark_index, while if providing only the fasta for indexing by the module BWAMETH_INDEX, it will pass to ch_bwameth_index.
I suppose ch_bismark_index here should be ch_bwameth_index, and this probably explains why using iGenome fasta or providing --bismark_index make the pipeline works.
I changed all ch_bismark_index to ch_bwameth_index and it works well now.

@sateeshperi sateeshperi added this to the 2.7.0 milestone Sep 17, 2024
@sateeshperi sateeshperi linked a pull request Sep 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants