Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow for pipelines #2854

Open
adamrtalbot opened this issue Mar 18, 2024 · 4 comments
Open

Update CI workflow for pipelines #2854

adamrtalbot opened this issue Mar 18, 2024 · 4 comments

Comments

@adamrtalbot
Copy link
Contributor

Description of feature

nf-core/fetchngs uses a new strategy based on scraping the information via Python to list and fetch all changed files, plus dependencies. It then lists all relevant nf-test files and uses them in a testing matrix.

ci.yml
Python script

We need to migrate this feature to the template. We should just be able to copy+paste the files.

nf-core/fetchngs#271
nf-core/fetchngs#300

@adamrtalbot
Copy link
Contributor Author

Should be able to merge this after #2992 is merged

@mirpedrol
Copy link
Member

Hi! Having a look at the way you test changed files and dependencies in fetchngs. Could we create an nf-core github action to avoid adding the python script to the pipeline template?

I was also wondering if this can be used in the modules repo. We want to test the subworkflows which use a module that has ben updated. Will this continue working if we completely remove tags?

@adamrtalbot
Copy link
Contributor Author

Hi! Having a look at the way you test changed files and dependencies in fetchngs. Could we create an nf-core github action to avoid adding the python script to the pipeline template?

Already done! no tags required. We can probably switch this for the native nf-test feature but I haven't tried it yet.

@mirpedrol
Copy link
Member

Hello, this seems to be solved, can I close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants