Merge pull request #4 from mdaus/warnings

Remove formal parameter warnings from BandSource.c

Author: asylvest

modules/c/nitf/source/BandSource.c

@@ -57,6 +57,7 @@ NITFPRIV(NITF_BOOL) MemorySource_contigRead(
         nitf_Off size,
         nitf_Error* error)
 {
+    (void) error; /* Suppresses a warning. Param seems to exist for consistency purposes. Not used. */
     memcpy(buf,
            (const nitf_Uint8*)memorySource->data + memorySource->mark,
            (size_t)size);
@@ -69,8 +70,9 @@ NITFPRIV(NITF_BOOL) MemorySource_offsetRead(
         MemorySourceImpl* memorySource,
         void* buf,
         nitf_Off size,
-        nitf_Error * error)
+        nitf_Error* error)
 {
+    (void) error;
     size_t destOffset = 0;
     const nitf_Uint8* const src = (const nitf_Uint8*)memorySource->data;
     nitf_Uint8* const dest = (nitf_Uint8*)buf;
@@ -121,18 +123,19 @@ NITFPRIV(void) MemorySource_destruct(NITF_DATA * data)
 }
 
 
-NITFPRIV(nitf_Off) MemorySource_getSize(NITF_DATA * data, nitf_Error *e)
+NITFPRIV(nitf_Off) MemorySource_getSize(NITF_DATA * data, nitf_Error* error)
 {
+    (void) error;
     MemorySourceImpl *memorySource = (MemorySourceImpl *) data;
     return memorySource ? memorySource->size : 0;
 }
 
-NITFPRIV(NITF_BOOL) MemorySource_setSize(NITF_DATA * data, nitf_Off size, nitf_Error *e)
+NITFPRIV(NITF_BOOL) MemorySource_setSize(NITF_DATA * data, nitf_Off size, nitf_Error *error)
 {
     MemorySourceImpl *memorySource = (MemorySourceImpl *) data;
     if (!memorySource)
     {
-        nitf_Error_init(e, "Null pointer reference",
+        nitf_Error_init(error, "Null pointer reference",
                 NITF_CTXT, NITF_ERR_INVALID_OBJECT);
         return NITF_FAILURE;
     }
@@ -221,19 +224,20 @@ NITFPRIV(void) FileSource_destruct(NITF_DATA * data)
     }
 }
 
-NITFPRIV(nitf_Off) IOSource_getSize(NITF_DATA * data, nitf_Error *e)
+NITFPRIV(nitf_Off) IOSource_getSize(NITF_DATA * data, nitf_Error* error)
 {
+    (void) error;
     IOSourceImpl *source = (IOSourceImpl *) data;
     return source ? (nitf_Off)source->size : 0;
 }
 
 
-NITFPRIV(NITF_BOOL) IOSource_setSize(NITF_DATA * data, nitf_Off size, nitf_Error *e)
+NITFPRIV(NITF_BOOL) IOSource_setSize(NITF_DATA * data, nitf_Off size, nitf_Error *error)
 {
     IOSourceImpl *source = (IOSourceImpl *) data;
     if (!source)
     {
-        nitf_Error_init(e, "Null pointer reference",
+        nitf_Error_init(error, "Null pointer reference",
                 NITF_CTXT, NITF_ERR_INVALID_OBJECT);
         return NITF_FAILURE;
     }