Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to provision Gateway on Helm install #1623

Closed
wants to merge 2 commits into from
Closed

Add support to provision Gateway on Helm install #1623

wants to merge 2 commits into from

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Problem: As a user of NGF, I would like to be able to deploy a Gateway resource as part of my Helm installation

Solution: Add support for creating a Gateway resource as part of a Helm install.

Testing: Tested locally installing various Gateway configurations using Helm

Closes #1533

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Added support to provision a Gateway resource as part of a Helm install.

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart labels Feb 28, 2024
@ciarams87 ciarams87 force-pushed the feat/deploy-gw-from-helm branch from 34015ea to 1b66f04 Compare February 29, 2024 12:49
@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (f33db51) to head (482f7bc).
Report is 176 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1623      +/-   ##
==========================================
+ Coverage   85.67%   85.71%   +0.03%     
==========================================
  Files          83       83              
  Lines        5181     5181              
==========================================
+ Hits         4439     4441       +2     
+ Misses        690      689       -1     
+ Partials       52       51       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ciarams87 ciarams87 force-pushed the feat/deploy-gw-from-helm branch from 1b66f04 to 482f7bc Compare February 29, 2024 14:07
@ciarams87 ciarams87 marked this pull request as ready for review February 29, 2024 14:21
@ciarams87 ciarams87 requested a review from a team as a code owner February 29, 2024 14:21
pleshakov
pleshakov reviewed Feb 29, 2024
View reviewed changes
deploy/helm-chart/templates/gateway.yaml
{{- end }}
spec:
gatewayClassName: {{ .Values.nginxGateway.gatewayClassName }}
listeners:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why can't we just include listeners as we include ports here https://github.com/nginxinc/nginx-gateway-fabric/blob/f33db51fc9e05ccf98fc8cdae100772a5cc6775e/deploy/helm-chart/values.yaml#L128-L136 ? What's the value of defining the fields of listeners?

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added stale Pull requests/issues with no activity and removed stale Pull requests/issues with no activity labels Mar 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added stale Pull requests/issues with no activity and removed stale Pull requests/issues with no activity labels Mar 31, 2024
@lucacome lucacome mentioned this pull request Apr 2, 2024
Open
5 tasks
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added stale Pull requests/issues with no activity and removed stale Pull requests/issues with no activity labels Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Apr 30, 2024
salonichf5
salonichf5 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@salonichf5 salonichf5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there conformance tests we can enable for this?

@github-actions github-actions bot removed the stale Pull requests/issues with no activity label May 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov left review comments

@sjberman sjberman sjberman left review comments

@salonichf5 salonichf5 salonichf5 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart stale Pull requests/issues with no activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm: provisioning "gateway" support for nginx-gateway-fabric helm chart
4 participants
@ciarams87 @pleshakov @sjberman @salonichf5