Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng-add should also work for ESLint 9 flat config files #4643

Open
2 tasks
timdeschryver opened this issue Dec 24, 2024 · 7 comments · May be fixed by #4698
Open
2 tasks

ng-add should also work for ESLint 9 flat config files #4643

timdeschryver opened this issue Dec 24, 2024 · 7 comments · May be fixed by #4698

Comments

@timdeschryver
Copy link
Member

Which @ngrx/* package(s) are relevant/related to the feature request?

eslint-plugin

Information

Currently the NgRx eslint plugin only configures the NgRx plugin within a json file.
We should also add the option to configure our plugin within flat config files.

The schematic should automatically detect which file needs to be updated.
We can take a look at the Angular ESlint plugin for inspiration https://github.com/angular-eslint/angular-eslint/blob/390df5a211f7016be1bcc12c4e139796c1867867/packages/schematics/src/ng-add/index.ts#L41

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@pawel-twardziak
Copy link
Contributor

@timdeschryver is it open for picking? I am willing to dive deep into the flat config.

@timdeschryver
Copy link
Member Author

@pawel-twardziak feel free to tackle this issue.
I'll assign you to it.

@pawel-twardziak
Copy link
Contributor

Ok @timdeschryver, I am on it, thanks

@pawel-twardziak
Copy link
Contributor

@timdeschryver sorry for the delay, the begining of the year was packed with vacation days. I am back on it.

@timdeschryver
Copy link
Member Author

No problem @pawel-twardziak , I hope you enjoyed your vacation.
Thanks in advance for working on this.

@adxdits
Copy link

adxdits commented Feb 8, 2025

Hello, I noticed this issue has been in progress for some time. If it's okay, I would be happy to take over :)

@pawel-twardziak
Copy link
Contributor

pawel-twardziak commented Feb 8, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants